ci(release-minor): add apm- prefix and create release diff between patches
#13065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
changed the title
apm- prefix and create release diff between patches
v1v
commented
May 2, 2024
v1v
commented
May 2, 2024
| @@ -39,7 +39,7 @@ PROJECT_PATCH_VERSION ?= $(shell echo $(RELEASE_VERSION) | cut -f3 -d.) | |||
| PROJECT_OWNER ?= elastic | |||
| RELEASE_TYPE ?= minor | |||
|
|
|||
| CURRENT_RELEASE ?= $(shell gh api repos/elastic/apm-server/releases/latest | jq -r '.tag_name|sub("v"; ""; "")') | |||
| CURRENT_RELEASE ?= $(shell gh release list --exclude-drafts --exclude-pre-releases --limit 10 --json tagName --jq '.[].tagName|select(. | startswith("v$(PROJECT_MAJOR_VERSION)"))' | sed 's|v||g' | sort -r | head -n 1) | |||
There was a problem hiding this comment.
We cannot use latest as long as latest can point to 7.17. I've already reported to the release team (Only accessible by Elastic employees)
I decided to use a different approach and filter by the major version and do some manipulation
v1v
added
backport-7.17
v1v
commented
May 2, 2024
| awk "NR==5{print \"\n* <<release-notes-$(VERSION).0>>\n\n[float]\n[[release-notes-$(VERSION).0]]\n=== APM version $(VERSION).0\"}1" changelogs/$(VERSION).asciidoc > changelogs/$(VERSION).asciidoc.new | ||
| mv changelogs/$(VERSION).asciidoc.new changelogs/$(VERSION).asciidoc | ||
| echo "$$CHANGELOG_MINOR_TMPL" > changelogs/$(VERSION).asciidoc | ||
| tail -n +6 changelogs/head.asciidoc >> changelogs/$(VERSION).asciidoc |
There was a problem hiding this comment.
as long as head.asciidoc uses the current format, we can use this approach, so less craziness commands to manipulate the file but using templates
reakaleek
approved these changes
May 6, 2024
endorama
approved these changes
May 6, 2024
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Support release automation for FF with:
apm-prefix to Asciidoc links and targetsTest
produced:
and
Checklist
For functional changes, consider:
How to test these changes
Related issues
Behaviour changed in #12820
Part of #12989