Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test SNAPSHOT in smoketests #13147

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented May 10, 2024

Motivation/summary

Support "latest" in lagacy-managed and legacy-standalone-major-managed by testing snapshots.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

(cd testing/smoke/legacy-standalone-major-managed && EC_API_KEY=redacted ./test.sh latest)
(cd testing/smoke/legacy-managed && EC_API_KEY=redacted ./test.sh latest)

Related issues

Part of #13051

Copy link
Contributor

mergify bot commented May 10, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 10, 2024
@carsonip carsonip marked this pull request as ready for review May 17, 2024 20:36
@carsonip carsonip requested a review from a team as a code owner May 17, 2024 20:36
@carsonip
Copy link
Member Author

carsonip commented May 17, 2024

This should be tested again when 7.17 snapshot is fixed. Currently 7.17.22-SNAPSHOT is broken and APM doesn't start after upgrade to 8.x.

@simitt
Copy link
Contributor

simitt commented May 21, 2024

Currently 7.17.22-SNAPSHOT is broken and APM doesn't start.

Could you link to a tracking issue for this please?

@carsonip
Copy link
Member Author

Currently 7.17.22-SNAPSHOT is broken and APM doesn't start.

Could you link to a tracking issue for this please?

The issue should be elastic/beats#39585

@carsonip
Copy link
Member Author

carsonip commented May 31, 2024

I can confirm that the 7.17 build is fixed and both updated smoke tests now pass for latest.

Copy link
Contributor

@inge4pres inge4pres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 thanks

@carsonip carsonip enabled auto-merge (squash) June 4, 2024 10:12
@carsonip carsonip disabled auto-merge June 4, 2024 10:12
@carsonip carsonip enabled auto-merge (squash) June 4, 2024 10:28
@carsonip carsonip merged commit 218cc96 into elastic:main Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants