Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 7.17.22-SNAPSHOT instead of 7.17.22 temporarilly #13315

Closed
wants to merge 1 commit into from

Conversation

kyungeunni
Copy link
Contributor

Motivation/summary

Temporarily use 7.17.22-SNAPSHOT for smoke tests when the desired version is 7.17.22.

Previously the 7.17.22-SNAPSHOT image was broken and now it's fixed. Now the 7.17.22 is broken for the same reason, and more recent build 7.17.22-SNAPSHOT is now working. Until 7.17.22 is properly fixed, we should use 7.17.22-SNAPSHOT.

How to test these changes

(cd testing/smoke/legacy-standalone-major-managed && EC_API_KEY=redacted ./test.sh 7.17)
(cd testing/smoke/legacy-managed && EC_API_KEY=redacted ./test.sh 7.17)

Related issues

#13147

@kyungeunni kyungeunni requested a review from a team as a code owner June 5, 2024 06:56
Copy link
Contributor

mergify bot commented Jun 5, 2024

This pull request does not have a backport label. Could you fix it @kyungeunni? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 5, 2024
@marclop
Copy link
Contributor

marclop commented Jun 5, 2024

I think it's not possible to upgrade a non-snapshot version deployment to a snapshot version. Did you check if this would work?

@kyungeunni
Copy link
Contributor Author

@marclop thanks for pointing this out, it doesn't indeed.

Also, this temporary fix isn't necessary anymore given that there are new builds available. I will close this.

@kyungeunni kyungeunni closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants