Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(smoke-tests): set id-token when running other workflows #13497

Merged
merged 1 commit into from
Jun 26, 2024
Merged

ci(smoke-tests): set id-token when running other workflows #13497

merged 1 commit into from
Jun 26, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 26, 2024

Motivation/summary

permissions need to be set explicitly when calling other workflows even if those workflows already have got the permissions set.

Fixes

[Invalid workflow file: .github/workflows/smoke-tests-schedule.yml#L27](https://github.com/elastic/apm-server/actions/runs/9672905228/workflow)
The workflow is not valid. .github/workflows/smoke-tests-schedule.yml (Line: 27, Col: 3): Error calling workflow 'elastic/apm-server/.github/workflows/smoke-tests-os.yml@4cf627cb98d0624f5206dfbfa30f88f64794c739'. The nested job 'smoke-tests-os' is requesting 'id-token: write', but is only allowed 'id-token: none'.

See https://github.com/elastic/apm-server/actions/runs/9672905228

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify labels Jun 26, 2024
@v1v v1v requested a review from a team June 26, 2024 10:40
@v1v v1v self-assigned this Jun 26, 2024
@v1v v1v requested a review from a team as a code owner June 26, 2024 10:40
@v1v v1v merged commit ba2125d into elastic:main Jun 26, 2024
10 checks passed
mergify bot pushed a commit that referenced this pull request Jun 26, 2024
@v1v @mergify
ci(smoke-tests): set id-token when running other workflows (#13497)
1d69ebd 
(cherry picked from commit ba2125d)
mergify bot pushed a commit that referenced this pull request Jun 26, 2024
@v1v @mergify
ci(smoke-tests): set id-token when running other workflows (#13497)
0cd3531 
(cherry picked from commit ba2125d)
This was referenced Jun 26, 2024
Merged
Merged
mergify bot added a commit that referenced this pull request Jun 26, 2024
@mergify @v1v
ci(smoke-tests): set id-token when running other workflows (#13497) (#…
815dfdd 
…13499)

(cherry picked from commit ba2125d)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
mergify bot added a commit that referenced this pull request Jun 26, 2024
@mergify @v1v
ci(smoke-tests): set id-token when running other workflows (#13497) (#…
f4a7fa3 
…13498)

(cherry picked from commit ba2125d)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Jun 26, 2024
@v1v
Merge remote-tracking branch 'upstream/main' into feature/use-oidc-aw…
cf28b76 
…s-apm-server-benchmarks-smoke-tests

* upstream/main:
  ci(smoke-tests): set id-token when running other workflows (#13497)
  build(deps): bump github.com/elastic/apm-data from 1.5.0 to 1.6.0 (#13494)
  ci(slack-message): fix the error (#13493)
  test: handle empty newlines in BenchmarkPublisher (#13484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reakaleek reakaleek reakaleek approved these changes

@kruskall kruskall kruskall approved these changes

Assignees

@v1v v1v

Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@v1v @reakaleek @kruskall