spec: add span.sync and index field

changelogs/head.asciidoc

@@ -7,3 +7,4 @@ https://github.com/elastic/apm-server/compare/6.5\...master[View commits]
 === Added
 
 - Set some configuration defaults (setup.template.settings.index.*, logging.metrics.enabled) in code {pull}1494[1494].
+- Add `span.sync` property to intake json spec and index field in ES. {pull}1548[1548].

docs/data/elasticsearch/generated/spans.json

@@ -152,6 +152,7 @@
                 "start": {
                     "us": 0
                 },
+                "sync": false,
                 "type": "request"
             },
             "timestamp": {
@@ -252,6 +253,7 @@
                 "start": {
                     "us": 2830
                 },
+                "sync": true,
                 "type": "db.postgresql.query"
             },
             "timestamp": {

docs/data/elasticsearch/span.json

@@ -71,6 +71,7 @@
         "start": {
             "us": 2830
         },
+        "sync": false,
         "type": "db.postgresql.query"
     },
     "transaction": {

docs/fields.asciidoc

@@ -811,6 +811,16 @@ format: duration
 Duration of the span, in microseconds.
 
 
+--
+
+*`span.sync`*::
++
+--
+type: boolean
+
+Indicates whether the span was executed synchronously or asynchronously.
+
+
 --
 
 *`span.parent`*::

docs/spec/spans/common_span.json

@@ -73,6 +73,10 @@
             "type": "string",
             "description": "Keyword of specific relevance in the service's domain (eg: 'db.postgresql.query', 'template.erb', etc)",
             "maxLength": 1024
+        },
+        "sync": {
+            "type": ["boolean", "null"],
+            "description": "Indicates whether the span was executed synchronously or asynchronously."
         }
     },
     "required": ["duration", "name", "type"]

model/span/_meta/fields.yml

@@ -58,6 +58,12 @@
               output_format: asMilliseconds
               output_precision: 0
 
+        - name: sync 
+          type: boolean
+          description: >
+            Indicates whether the span was executed synchronously or asynchronously.
+
+
         - name: parent
           type: long
           description: >

model/span/event.go

@@ -63,6 +63,7 @@ type Event struct {
 
 	Timestamp     time.Time
 	TransactionId string
+	Sync          *bool
 
 	// new in v2
 	HexId    string
@@ -155,6 +156,7 @@ func decodeEvent(input interface{}, err error) (*Event, map[string]interface{},
 		Start:    decoder.Float64Ptr(raw, "start"),
 		Duration: decoder.Float64(raw, "duration"),
 		Context:  decoder.MapStr(raw, "context"),
+		Sync:     decoder.BoolPtr(raw, "sync"),
 	}
 	var stacktr *m.Stacktrace
 	stacktr, err = m.DecodeStacktrace(raw["stacktrace"], decoder.Err)
@@ -217,6 +219,7 @@ func (s *Event) fields(tctx *transform.Context) common.MapStr {
 
 	utility.Add(tr, "name", s.Name)
 	utility.Add(tr, "type", s.Type)
+	utility.Add(tr, "sync", s.Sync)
 
 	if s.Start != nil {
 		utility.Add(tr, "start", utility.MillisAsMicros(*s.Start))

model/span/generated/schema/span.go

@@ -165,6 +165,10 @@ const ModelSchema = `{
             "type": "string",
             "description": "Keyword of specific relevance in the service's domain (eg: 'db.postgresql.query', 'template.erb', etc)",
             "maxLength": 1024
+        },
+        "sync": {
+            "type": ["boolean", "null"],
+            "description": "Indicates whether the span was executed synchronously or asynchronously."
         }
     },
     "required": ["duration", "name", "type"]  },

model/transaction/generated/schema/payload.go

@@ -565,6 +565,10 @@ const PayloadSchema = `{
             "type": "string",
             "description": "Keyword of specific relevance in the service's domain (eg: 'db.postgresql.query', 'template.erb', etc)",
             "maxLength": 1024
+        },
+        "sync": {
+            "type": ["boolean", "null"],
+            "description": "Indicates whether the span was executed synchronously or asynchronously."
         }
     },
     "required": ["duration", "name", "type"]  }, 

processor/stream/approved-es-documents/testV2IntakeIntegrationSpans.approved.json

@@ -152,6 +152,7 @@
                 "start": {
                     "us": 0
                 },
+                "sync": false,
                 "type": "request"
             },
             "timestamp": {
@@ -252,6 +253,7 @@
                 "start": {
                     "us": 2830
                 },
+                "sync": true,
                 "type": "db.postgresql.query"
             },
             "timestamp": {

processor/transaction/package_tests/TestProcessTransactionFull.approved.json

@@ -214,6 +214,7 @@
                 "start": {
                     "us": 2830
                 },
+                "sync": false,
                 "type": "db.postgresql.query"
             },
             "transaction": {