move trace.transaction_id to trace.transaction.id #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalvz
changed the title
jalvz
force-pushed
the
transaction-id
branch
from
57ee52e
to
a8f1c71
Compare
simitt
approved these changes
Nov 24, 2017
|
Nice work! |
|
Leading up to GA in 6.2, I think we need to add breaking changes like this to a topic on APM weekly or something like that. It's too easy to miss mentions and comments:
|
|
Also, this includes a new task for the APM Server team to update the dashboards. |
|
There's also the meta issue. Add a Breaking changes checklist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #291
note: this will break kibana UI badly