Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fixes URLs on Secure communication with APM Agents page #4746

Merged
merged 4 commits into from Feb 17, 2021
Merged

[DOCS] Fixes URLs on Secure communication with APM Agents page #4746

merged 4 commits into from Feb 17, 2021

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Feb 17, 2021 •
edited

Overview

This PR fixes a bad link that breaks the build.

@apmmachine
Copy link
Collaborator

apmmachine commented Feb 17, 2021 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4746 updated

  • Start Time: 2021-02-17T09:58:19.683+0000

  • Duration: 41 min 8 sec

  • Commit: fd671fc

Test stats 🧪

Test Results
Failed 0
Passed 4751
Skipped 124
Total 4875

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 1

Expand to view the steps failures

Test Sync
  • Took 3 min 20 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@szabosteve
Copy link
Contributor Author

@elasticmachine update branch

axw
axw approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This means we'll lose the .NET Agent link until the docs are fixed, but better that than block all the builds.

@axw axw enabled auto-merge (squash) February 17, 2021 09:41
@axw
Copy link
Member

axw commented Feb 17, 2021

@bmorelli25 we'll need to replace the .NET Agent link later. Seems the 1.8.0 release broke the docs builds.

@axw axw merged commit 045813d into elastic:master Feb 17, 2021
@szabosteve szabosteve deleted the fix.docs.build branch February 17, 2021 10:40
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
5fe7933 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
924582b 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
d7e4205 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
2731062 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
fcaef54 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
8b628c7 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
b5e0d12 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
a0a6d00 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
61592f1 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
a8566e1 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
szabosteve added a commit to szabosteve/apm-server that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (elast…
2ef5767 
…ic#4746)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@szabosteve szabosteve mentioned this pull request Feb 17, 2021
Merged
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
3510469 
#4752)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
c676450 
#4754)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
c2f6afc 
#4749)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
szabosteve added a commit that referenced this pull request Feb 17, 2021
@szabosteve
Merge pull request #4750 from szabosteve/backport/7.11/pr-4746
117f534 
[7.11] [DOCS] Fixes URLs on Secure communication with APM Agents page (#4746)
szabosteve added a commit that referenced this pull request Feb 17, 2021
@szabosteve
Merge pull request #4751 from szabosteve/backport/7.10/pr-4746
8ac4b8f 
[7.10] [DOCS] Fixes URLs on Secure communication with APM Agents page (#4746)
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
bab0d40 
#4755)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
e76d5aa 
#4756)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
d11b5e8 
#4758)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
4d69a71 
#4759)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
f7e76e5 
#4760)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
axw pushed a commit that referenced this pull request Feb 17, 2021
@szabosteve
[DOCS] Fixes URLs on Secure communication with APM Agents page (#4746) (
50b8b23 
#4757)

* [DOCS] Fixes URLs on Secure communication with APM Agents page.

* [DOCS] Comments out link.
@bmorelli25 bmorelli25 mentioned this pull request Feb 17, 2021
Merged
v1v added a commit to v1v/apm-server that referenced this pull request Feb 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/pr-json-s…
8efeb57 
…chemas-to-agents

* upstream/master: (111 commits)
  Introduce metricset.name (elastic#4857)
  processor/otel: test service.version handling (elastic#4853)
  docs: Add PHP agent information to shared docs (elastic#4740)
  Script for faster development workflow (elastic#4731)
  Update to elastic/beats@1b31c26 (elastic#4763)
  backport: add 7.12 to .backportrc.json (elastic#4807)
  backport: enable auto-merge on backport PRs (elastic#4777)
  Support for Node.js profiles (elastic#4728)
  docs: readds .NET link (elastic#4764)
  [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746)
  ci: set proper parameters for the tar step (elastic#4696)
  docs: add 7.11.1 release notes (elastic#4727)
  Disable sourcemap upload endpoint when data streams enabled (elastic#4735)
  Add service name to dataset field (elastic#4674)
  Update to elastic/beats@ba423212a660 (elastic#4733)
  sampling: require a default policy (elastic#4729)
  processor/otel: add unit test for span status (elastic#4734)
  Add support for consuming OTLP/gRPC metrics (elastic#4722)
  [apmpackage] Add config options supported in ESS (elastic#4690)
  Use the apm-server version everywhere* (elastic#4725)
  ...
v1v added a commit to v1v/apm-server that referenced this pull request Feb 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/jjbb-upda…
ca623cf 
…te-schema-json-1

* upstream/master: (111 commits)
  Introduce metricset.name (elastic#4857)
  processor/otel: test service.version handling (elastic#4853)
  docs: Add PHP agent information to shared docs (elastic#4740)
  Script for faster development workflow (elastic#4731)
  Update to elastic/beats@1b31c26 (elastic#4763)
  backport: add 7.12 to .backportrc.json (elastic#4807)
  backport: enable auto-merge on backport PRs (elastic#4777)
  Support for Node.js profiles (elastic#4728)
  docs: readds .NET link (elastic#4764)
  [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746)
  ci: set proper parameters for the tar step (elastic#4696)
  docs: add 7.11.1 release notes (elastic#4727)
  Disable sourcemap upload endpoint when data streams enabled (elastic#4735)
  Add service name to dataset field (elastic#4674)
  Update to elastic/beats@ba423212a660 (elastic#4733)
  sampling: require a default policy (elastic#4729)
  processor/otel: add unit test for span status (elastic#4734)
  Add support for consuming OTLP/gRPC metrics (elastic#4722)
  [apmpackage] Add config options supported in ESS (elastic#4690)
  Use the apm-server version everywhere* (elastic#4725)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
docs v7.1.0 v7.2.0 v7.3.0 v7.5.0 v7.6.1 v7.7.0 v7.8.0 v7.9.3 v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szabosteve @apmmachine @axw