Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor/otel: test service.version handling #4853

Merged
merged 2 commits into from Feb 22, 2021

Conversation

axw
Copy link
Member

@axw axw commented Feb 21, 2021

Motivation/summary

Add a test that shows that we support setting
service.version using Jaeger process tags or
OTLP resource attributes, and support overriding
using span tags.

How to test these changes

Non-functional change. This PR only adds a test.

Related issues

#4319

Add a test that shows that we support setting
service.version using Jaeger process tags or
OTLP resource attributes, and support overriding
using span tags.
@apmmachine
Copy link
Collaborator

apmmachine commented Feb 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4853 updated

  • Start Time: 2021-02-21T08:00:26.302+0000

  • Duration: 45 min 18 sec

  • Commit: 82715be

Test stats 🧪

Test Results
Failed 0
Passed 4754
Skipped 124
Total 4878

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 1

Expand to view the steps failures

Test Sync
  • Took 4 min 31 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@axw axw requested a review from a team February 21, 2021 08:00
@codecov-io
Copy link

Codecov Report

Merging #4853 (82715be) into master (2ce65df) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4853      +/-   ##
==========================================
+ Coverage   76.76%   76.82%   +0.05%     
==========================================
  Files         166      166              
  Lines       10244    10244              
==========================================
+ Hits         7864     7870       +6     
+ Misses       2380     2374       -6     
Impacted Files Coverage Δ
beater/beater.go 70.22% <0.00%> (-0.37%) ⬇️
processor/otel/metadata.go 63.23% <0.00%> (+2.94%) ⬆️
kibana/connecting_client.go 76.56% <0.00%> (+7.81%) ⬆️

@axw axw merged commit 742d429 into elastic:master Feb 22, 2021
@axw axw deleted the jaeger-service-version branch February 22, 2021 01:36
axw added a commit to axw/apm-server that referenced this pull request Feb 22, 2021
Add a test that shows that we support setting
service.version using Jaeger process tags or
OTLP resource attributes, and support overriding
using span tags.
v1v added a commit to v1v/apm-server that referenced this pull request Feb 22, 2021
…chemas-to-agents

* upstream/master: (111 commits)
  Introduce metricset.name (elastic#4857)
  processor/otel: test service.version handling (elastic#4853)
  docs: Add PHP agent information to shared docs (elastic#4740)
  Script for faster development workflow (elastic#4731)
  Update to elastic/beats@1b31c26 (elastic#4763)
  backport: add 7.12 to .backportrc.json (elastic#4807)
  backport: enable auto-merge on backport PRs (elastic#4777)
  Support for Node.js profiles (elastic#4728)
  docs: readds .NET link (elastic#4764)
  [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746)
  ci: set proper parameters for the tar step (elastic#4696)
  docs: add 7.11.1 release notes (elastic#4727)
  Disable sourcemap upload endpoint when data streams enabled (elastic#4735)
  Add service name to dataset field (elastic#4674)
  Update to elastic/beats@ba423212a660 (elastic#4733)
  sampling: require a default policy (elastic#4729)
  processor/otel: add unit test for span status (elastic#4734)
  Add support for consuming OTLP/gRPC metrics (elastic#4722)
  [apmpackage] Add config options supported in ESS (elastic#4690)
  Use the apm-server version everywhere* (elastic#4725)
  ...
v1v added a commit to v1v/apm-server that referenced this pull request Feb 22, 2021
…te-schema-json-1

* upstream/master: (111 commits)
  Introduce metricset.name (elastic#4857)
  processor/otel: test service.version handling (elastic#4853)
  docs: Add PHP agent information to shared docs (elastic#4740)
  Script for faster development workflow (elastic#4731)
  Update to elastic/beats@1b31c26 (elastic#4763)
  backport: add 7.12 to .backportrc.json (elastic#4807)
  backport: enable auto-merge on backport PRs (elastic#4777)
  Support for Node.js profiles (elastic#4728)
  docs: readds .NET link (elastic#4764)
  [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746)
  ci: set proper parameters for the tar step (elastic#4696)
  docs: add 7.11.1 release notes (elastic#4727)
  Disable sourcemap upload endpoint when data streams enabled (elastic#4735)
  Add service name to dataset field (elastic#4674)
  Update to elastic/beats@ba423212a660 (elastic#4733)
  sampling: require a default policy (elastic#4729)
  processor/otel: add unit test for span status (elastic#4734)
  Add support for consuming OTLP/gRPC metrics (elastic#4722)
  [apmpackage] Add config options supported in ESS (elastic#4690)
  Use the apm-server version everywhere* (elastic#4725)
  ...
axw added a commit that referenced this pull request Feb 25, 2021
Add a test that shows that we support setting
service.version using Jaeger process tags or
OTLP resource attributes, and support overriding
using span tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants