Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mergify] add backport policy and default label #6186

Merged
merged 5 commits into from
Sep 20, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 16, 2021

Motivation/summary

Notify PR contributors about the backport policy.

This policy will notify what are the different backport options and tag the PR with the backport-skip.

We can think about enforcing this rule to do not allow merges but for the time being, what do you think?

Test

See elastic/apm-pipeline-library#1281 (comment) and elastic/apm-pipeline-library#1281 (comment)

@v1v v1v requested review from a team September 16, 2021 11:48
@apmmachine
Copy link
Contributor

apmmachine commented Sep 16, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-20T11:32:12.233+0000

  • Duration: 39 min 56 sec

  • Commit: ef21ebe

Test stats 🧪

Test Results
Failed 0
Passed 6101
Skipped 14
Total 6115

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @v1v

We can think about enforcing this rule to do not allow merges but for the time being, what do you think?

I think this is a good step. If the nudge isn't enough, then we can come back to blocking merges.

.mergify.yml Outdated Show resolved Hide resolved
.mergify.yml Outdated Show resolved Hide resolved
.mergify.yml Outdated Show resolved Hide resolved
@v1v
Copy link
Member Author

v1v commented Sep 20, 2021

There is a missing bit regarding skipping the backports validation

@v1v v1v merged commit a50aa8e into elastic:master Sep 20, 2021
@v1v v1v deleted the feature/mergify-backport-policy branch September 20, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants