Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for transaction.name in an error object to the intake API #6539

Merged
merged 3 commits into from Nov 4, 2021
Merged

Added support for transaction.name in an error object to the intake API #6539

merged 3 commits into from Nov 4, 2021

Conversation

tobiasstadler
Copy link
Contributor

Motivation/summary

Fixes #6529

Checklist

How to test these changes

I added unit tests

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

This pull request does not have a backport label. Could you fix it @tobiasstadler? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 4, 2021
@tobiasstadler tobiasstadler changed the title Added support for transaction.name to the intake API Added support for transaction.name in an error object to the intake API Nov 4, 2021
@tobiasstadler
Copy link
Contributor Author

I ran make update this time

@apmmachine
Copy link
Collaborator

apmmachine commented Nov 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-04T09:23:38.985+0000

  • Duration: 39 min 27 sec

  • Commit: 290b38d

Test stats 🧪

Test Results
Failed 0
Passed 6258
Skipped 19
Total 6277

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, you're quick :) Thank you!

@axw axw added the backport-8.0 Automated backport with mergify label Nov 4, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 4, 2021
@axw axw added the v8.0.0 label Nov 4, 2021
@axw
Copy link
Member

axw commented Nov 4, 2021

/test

@tobiasstadler
Copy link
Contributor Author

Thank You!

@tobiasstadler tobiasstadler deleted the fix-6529 branch November 4, 2021 10:16
marclop pushed a commit that referenced this pull request Nov 4, 2021
…PI (#6539) (#6542)

* Added support for transaction.name to the intake API

* Added #6539 to the changelog

* Improved Changelog

(cherry picked from commit fe1db82)

Co-authored-by: Tobias Stadler <ts.stadler@gmx.de>
@stuartnelson3
Copy link
Contributor

test plan: ingest an error, verify transaction.name is set

@marclop
Copy link
Contributor

marclop commented Dec 21, 2021

Tested locally ingesting some errors with 8.0.0-dev4 package but we missed adding the transaction.name field mapping to the data stream:

Error detail

image

Data Stream mapping

image

@marclop
Copy link
Contributor

marclop commented Dec 28, 2021

Verified this with 42889b4, which contains the linked PR's fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow transaction.name in error events
5 participants