address pr comments

elastic · May 11, 2023 · 2e4a7e6 · 2e4a7e6
1 parent 238c351
commit 2e4a7e6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/filebeat/input/httpjson/encoding.go b/x-pack/filebeat/input/httpjson/encoding.go
@@ -226,11 +226,11 @@ func decodeAsZip(p []byte, dst *response) error {
 }
 
 func decodeAsXML(p []byte, dst *response) error {
-	cdata, v, err := xml.Unmarshal(bytes.NewReader(p), dst.xmlDetails)
+	cdata, body, err := xml.Unmarshal(bytes.NewReader(p), dst.xmlDetails)
 	if err != nil {
 		return err
 	}
-	dst.body = v
+	dst.body = body
 	dst.header["XML-CDATA"] = []string{cdata}
 	return nil
 }
diff --git a/x-pack/filebeat/input/httpjson/input.go b/x-pack/filebeat/input/httpjson/input.go
@@ -134,7 +134,7 @@ func run(
 	if config.Response.XSD != "" {
 		xmlDetails, err = xml.Details([]byte(config.Response.XSD))
 		if err != nil {
-			log.Errorf("Error while creating requestFactory: %v", err)
+			log.Errorf("error while collecting xml decoder type hints: %v", err)
 			return err
 		}
 	}

diff --git a/x-pack/filebeat/input/httpjson/request.go b/x-pack/filebeat/input/httpjson/request.go
@@ -133,7 +133,7 @@ func newRequestFactory(ctx context.Context, config config, log *logp.Logger) ([]
 		var err error
 		xmlDetails, err = xml.Details([]byte(config.Response.XSD))
 		if err != nil {
-			log.Errorf("Error while creating requestFactory: %v", err)
+			log.Errorf("error while collecting xml decoder type hints: %v", err)
 			return nil, err
 		}
 	}