defer body close

elastic · Nov 30, 2023 · 4082276 · 4082276
1 parent ad0a9e8
commit 4082276
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/x-pack/metricbeat/module/awsfargate/task_stats/task_stats.go b/x-pack/metricbeat/module/awsfargate/task_stats/task_stats.go
@@ -137,6 +137,8 @@ func (m *MetricSet) queryTaskMetadataEndpoints() ([]Stats, error) {
 	if err != nil {
 		return nil, fmt.Errorf("http.Get failed: %w", err)
 	}
+	defer taskStatsResp.Body.Close()
+
 	taskStatsOutput, err := getTaskStats(taskStatsResp)
 	if err != nil {
 		return nil, fmt.Errorf("getTaskStats failed: %w", err)
@@ -151,6 +153,8 @@ func (m *MetricSet) queryTaskMetadataEndpoints() ([]Stats, error) {
 	if err != nil {
 		return nil, fmt.Errorf("http.Get failed: %w", err)
 	}
+	defer taskResp.Body.Close()
+
 	taskOutput, err := getTask(taskResp)
 	if err != nil {
 		return nil, fmt.Errorf("getTask failed: %w", err)

diff --git a/x-pack/metricbeat/module/awsfargate/task_stats/task_stats_integration_test.go b/x-pack/metricbeat/module/awsfargate/task_stats/task_stats_integration_test.go
@@ -31,9 +31,11 @@ func TestFetch(t *testing.T) {
 
 	taskStatsResp, err := buildResponse("./_meta/testdata/task_stats.json")
 	assert.NoError(t, err)
+	defer taskStatsResp.Body.Close()
 
 	byteTaskResp, err := buildResponse("./_meta/testdata/task.json")
 	assert.NoError(t, err)
+	defer byteTaskResp.Body.Close()
 
 	taskStatsOutput, err := getTaskStats(taskStatsResp)
 	assert.NoError(t, err)
@@ -69,9 +71,11 @@ func TestData(t *testing.T) {
 
 	taskStatsResp, err := buildResponse("./_meta/testdata/task_stats.json")
 	assert.NoError(t, err)
+	defer taskStatsResp.Body.Close()
 
 	byteTaskResp, err := buildResponse("./_meta/testdata/task.json")
 	assert.NoError(t, err)
+	defer byteTaskResp.Body.Close()
 
 	taskStatsOutput, err := getTaskStats(taskStatsResp)
 	assert.NoError(t, err)