@timestamp doesnt get printed when specfied in message codec (#3721)

elastic · Mar 28, 2017 · 715593c · 715593c
1 parent 419d46f
commit 715593c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/libbeat/common/datetime.go b/libbeat/common/datetime.go
@@ -43,12 +43,17 @@ func ParseTime(timespec string) (Time, error) {
 	return Time(t), err
 }
 
+func (t Time) String() string {
+	return time.Time(t).Format(TsLayout)
+}
+
 // MustParseTime is a convenience equivalent of the ParseTime function
 // that panics in case of errors.
 func MustParseTime(timespec string) Time {
 	ts, err := ParseTime(timespec)
 	if err != nil {
 		panic(err)
 	}
+
 	return ts
 }
diff --git a/libbeat/common/fmtstr/formatevents.go b/libbeat/common/fmtstr/formatevents.go
@@ -408,6 +408,7 @@ func fieldString(event common.MapStr, field string) (string, error) {
 	if err != nil {
 		logp.Warn("Can not convert key '%v' value to string", v)
 	}
+
 	return s, err
 }
 
@@ -419,6 +420,8 @@ func tryConvString(v interface{}) (string, error) {
 	switch s := v.(type) {
 	case string:
 		return s, nil
+	case common.Time:
+		return s.String(), nil
 	case []byte:
 		return string(s), nil
 	case stringer:

diff --git a/libbeat/common/fmtstr/formatevents_test.go b/libbeat/common/fmtstr/formatevents_test.go
@@ -91,6 +91,18 @@ func TestEventFormatString(t *testing.T) {
 			"timestamp: 2015.05.01",
 			[]string{"key"},
 		},
+		{
+			"test timestamp formatter",
+			"%{[@timestamp]}: %{+YYYY.MM.dd}",
+			common.MapStr{
+				"@timestamp": common.Time(
+					time.Date(2015, 5, 1, 20, 12, 34, 0, time.Local),
+				),
+				"key": "timestamp",
+			},
+			"2015-05-01T20:12:34.000Z: 2015.05.01",
+			[]string{"@timestamp"},
+		},
 	}
 
 	for i, test := range tests {