Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
efd6 committed May 8, 2024
1 parent 71cf99d commit 79d5b0a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions x-pack/filebeat/docs/inputs/input-http-endpoint.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,12 @@ observe the activity of the input.
| `api_errors_total` | Number of API errors.
| `batches_received_total` | Number of event arrays received.
| `batches_published_total` | Number of event arrays published.
| `batches_acked_total` | Number of event arrays ACKed.
| `events_published_total` | Number of events published.
| `size` | Histogram of request content lengths.
| `batch_size` | Histogram of the received event array length.
| `batch_processing_time` | Histogram of the elapsed successful batch processing times in nanoseconds (time of receipt to time of ACK for non-empty batches).
| `batch_ack_time` | Histogram of the elapsed successful batch ACKing times in nanoseconds (time of handler start to time of ACK for non-empty batches).
|=======

[id="{beatname_lc}-input-{type}-common-options"]
Expand Down
4 changes: 2 additions & 2 deletions x-pack/filebeat/input/http_endpoint/ack.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ func newBatchACKTracker(fn func()) *batchACKTracker {
}

// Ready signals that the batch has been fully consumed. Only
// after the batch is marked as "ready" can the lumberjack batch
// be ACKed. This prevents the batch from being ACKed prematurely.
// after the batch is marked as "ready" can the batch be ACKed.
// This prevents the batch from being ACKed prematurely.
func (t *batchACKTracker) Ready() {
t.ACK()
}
Expand Down

0 comments on commit 79d5b0a

Please sign in to comment.