Skip to content

Commit

Permalink
Fix issue where --insecure didn't propogate to Fleet Server ES connec…
Browse files Browse the repository at this point in the history
…tion (#27969)

* Fix issue where --insecure didn't propogate to Fleet Server ES connection.

* Add changelog.
  • Loading branch information
blakerouse committed Sep 16, 2021
1 parent 455a733 commit cbbe8c2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions x-pack/elastic-agent/CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
- Add "_monitoring" suffix to monitoring instance names to remove ambiguity with the status command. {issue}25449[25449]
- Ignore ErrNotExists when fixing permissions. {issue}27836[27836] {pull}27846[27846]
- Snapshot artifact lookup will use agent.download proxy settings. {issue}27903[27903] {pull}27904[27904]
- Fix issue where --insecure didn't propogate to Fleet Server ES connection. {pull}27969[27969]

==== New features

Expand Down
10 changes: 9 additions & 1 deletion x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ func (c *enrollCmd) fleetServerBootstrap(ctx context.Context) (string, error) {
c.options.FleetServer.ConnStr, c.options.FleetServer.ServiceToken,
c.options.FleetServer.PolicyID,
c.options.FleetServer.Host, c.options.FleetServer.Port,
c.options.Insecure,
c.options.FleetServer.Cert, c.options.FleetServer.CertKey, c.options.FleetServer.ElasticsearchCA,
c.options.FleetServer.Headers,
c.options.ProxyURL,
Expand Down Expand Up @@ -495,6 +496,7 @@ func (c *enrollCmd) enroll(ctx context.Context, persistentConfig map[string]inte
c.options.FleetServer.ConnStr, c.options.FleetServer.ServiceToken,
c.options.FleetServer.PolicyID,
c.options.FleetServer.Host, c.options.FleetServer.Port,
c.options.Insecure,
c.options.FleetServer.Cert, c.options.FleetServer.CertKey, c.options.FleetServer.ElasticsearchCA,
c.options.FleetServer.Headers,
c.options.ProxyURL, c.options.ProxyDisabled, c.options.ProxyHeaders)
Expand Down Expand Up @@ -800,7 +802,7 @@ func storeAgentInfo(s saver, reader io.Reader) error {

func createFleetServerBootstrapConfig(
connStr, serviceToken, policyID, host string,
port uint16,
port uint16, insecure bool,
cert, key, esCA string,
headers map[string]string,
proxyURL string,
Expand Down Expand Up @@ -858,6 +860,12 @@ func createFleetServerBootstrapConfig(
},
}
}
if insecure {
if cfg.Server.TLS == nil {
cfg.Server.TLS = &tlscommon.Config{}
}
cfg.Server.TLS.VerificationMode = tlscommon.VerifyNone
}

if localFleetServer {
cfg.Client.Transport.Proxy.Disable = true
Expand Down

0 comments on commit cbbe8c2

Please sign in to comment.