Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Docker autodiscovery generates monitors for non-published ports #12178

Closed
eigengrau opened this issue May 12, 2019 · 4 comments
Closed
Labels
Heartbeat Stalled Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@eigengrau
Copy link

We are running a scheduled container environment (Nomad), so I was looking into leveraging the Docker autodiscovery provider to set up monitors dynamically (Heartbeat 7.0.1 run inside Docker with host networking). However, it appears that when a container exposes a port, but that port is not published, the Docker autodiscovery provider will still set up a monitor. This monitor will then permanently report failure due to the port not being reachable.

It would be convenient if monitors would not be set up unless the corresponding port is published to the host. Alternatively, it would be useful if the discovery data included a flag indicating whether the container port is published, so that the configured autodiscovery template could filter such containers using a conditional.

@ruflin ruflin added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label May 13, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime

@andrewvc
Copy link
Contributor

andrewvc commented Jun 3, 2019

@exekias would be curious to hear your thoughts on this.

@exekias
Copy link
Contributor

exekias commented Jun 3, 2019

This sounds like a reasonable ask, this is where all this happens:

"port": port.PrivatePort,
, we could add more data to Docker events, may be publicport and privateport fields? That would give enough info to make distinctions

@botelastic
Copy link

botelastic bot commented Jul 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Jul 8, 2020
@botelastic botelastic bot closed this as completed Aug 7, 2020
@zube zube bot removed the [zube]: Done label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Heartbeat Stalled Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

No branches or pull requests

5 participants