Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to easily disable outputs #1589

Closed
tsg opened this issue May 9, 2016 · 5 comments
Closed

Add option to easily disable outputs #1589

tsg opened this issue May 9, 2016 · 5 comments

Comments

@tsg
Copy link
Contributor

tsg commented May 9, 2016

One currently needs to comment out the whole section to disable an output. Because metricbeat has the option to use enable: false to quickly disable modules, it makes sense to add the same for the outputs at libbeat level.

@tsg
Copy link
Contributor Author

tsg commented May 9, 2016

Loosely related to #1417.

@drenalin23
Copy link

Any idea why this was removed from filebeat before 1.0.0 version? It made it into the filebeat cookbook (which now doesn't work as expected by reading the docs) and would be an extremely useful option when working configuration management to have a toggle for nodes/roles/environments instead of having to add/remove/comment out entire sections. Sorry if I'm ignorant of the overall architecture but hoping that adding this back to libbeat might push it upstream to filebeat.

In my use case I was rolling out filebeat to several environments, so wanted to setup the same config everywhere and then rollout it one environment at a time, planning on setting enabled to true as I went along.

@drenalin23
Copy link

For reference if this is implemented it is useful in the chef supermarket cookbook. vkhatri/chef-filebeat#55

@andrewkroh
Copy link
Member

Original proposal to remove: https://github.com/elastic/libbeat/issues/264

Summary: We had both enabled and disabled options with varying defaults and it was confusing. Adding back just enabled should be fine if the default is consistent everywhere that it is used.

@tsg
Copy link
Contributor Author

tsg commented Aug 23, 2016

This should be done now in master.

@tsg tsg closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants