Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] translate_sid should skip empty target fields #18990

Closed
andrewkroh opened this issue Jun 5, 2020 · 2 comments · Fixed by #18991
Closed

[libbeat] translate_sid should skip empty target fields #18990

andrewkroh opened this issue Jun 5, 2020 · 2 comments · Fixed by #18991
Labels
bug libbeat :Processors Team:Services (Deprecated) Label for the former Integrations-Services team :Windows

Comments

@andrewkroh
Copy link
Member

The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2020
@andrewkroh andrewkroh mentioned this issue Jun 5, 2020
Merged
4 tasks
andrewkroh added a commit to andrewkroh/beats that referenced this issue Jun 5, 2020
@andrewkroh
Fix translate_sid's empty target field handling
3e996df 
The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes elastic#18990
@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Jun 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2020
andrewkroh added a commit that referenced this issue Jun 9, 2020
@andrewkroh
Fix translate_sid's empty target field handling (#18991)
baccaad 
The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes #18990
@andrewkroh andrewkroh mentioned this issue Jun 9, 2020
Merged
4 tasks
andrewkroh added a commit to andrewkroh/beats that referenced this issue Jun 9, 2020
@andrewkroh
Fix translate_sid's empty target field handling (elastic#18991)
380e029 
The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes elastic#18990

(cherry picked from commit baccaad)
andrewkroh added a commit to andrewkroh/beats that referenced this issue Jun 9, 2020
@andrewkroh
Fix translate_sid's empty target field handling (elastic#18991)
f1cd824 
The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes elastic#18990

(cherry picked from commit baccaad)
@andrewkroh andrewkroh mentioned this issue Jun 9, 2020
Merged
4 tasks
andrewkroh added a commit to andrewkroh/beats that referenced this issue Jun 9, 2020
@andrewkroh
Fix translate_sid's empty target field handling (elastic#18991)
2ad4960 
The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes elastic#18990

(cherry picked from commit baccaad)
@andrewkroh andrewkroh mentioned this issue Jun 9, 2020
Merged
4 tasks
andrewkroh added a commit that referenced this issue Jun 10, 2020
@andrewkroh
Fix translate_sid's empty target field handling (#18991) (#19083)
45d6ee7 
The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes #18990

(cherry picked from commit baccaad)
andrewkroh added a commit that referenced this issue Jun 10, 2020
@andrewkroh
Cherry-pick #18991 to 7.8: Fix translate_sid's empty target field han…
1373cc9 
…dling (#19084)

The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes #18990

(cherry picked from commit baccaad)
andrewkroh added a commit that referenced this issue Jun 10, 2020
@andrewkroh
Cherry-pick #18991 to 7.7: Fix translate_sid's empty target field han…
a69894f 
…dling (#19085)

The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes #18990

(cherry picked from commit baccaad)
@andrewkroh
Copy link
Member Author

Fixed in #18991 targeting v7.7.2, v7.8.0, and v7.9.0.

melchiormoulin pushed a commit to melchiormoulin/beats that referenced this issue Oct 14, 2020
@andrewkroh @melchiormoulin
Fix translate_sid's empty target field handling (elastic#18991)
c0eceaf 
The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes elastic#18990
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@andrewkroh
Cherry-pick elastic#18991 to 7.7: Fix translate_sid's empty target fi…
033d688 
…eld handling (elastic#19085)

The translate_sid processor only requires one of the three target fields to be configured. It should work properly when some of the targets are not set, but it doesn't check if the are empty strings. So it ends up adding target fields that are empty strings to the event (e.g. "": "Group").

Closes elastic#18990

(cherry picked from commit 4b19f09)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug libbeat :Processors Team:Services (Deprecated) Label for the former Integrations-Services team :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix translate_sid's empty target field handling andrewkroh/beats
3 participants
@andresrc @andrewkroh @elasticmachine