Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS logging] Enable by default #23871

Closed
simitt opened this issue Feb 5, 2021 · 6 comments
Closed

[ECS logging] Enable by default #23871

simitt opened this issue Feb 5, 2021 · 6 comments
Assignees
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@simitt
Copy link
Contributor

simitt commented Feb 5, 2021

Following up on #17974 let's set the logging.ecs: true as default for 7.12. Since ECS formatter expect JSON format, it would make sense to also set logging.json: true by default.

@kvch and @urso WDYT?

side note: APM Server sets it as default in 7.11.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 5, 2021
@simitt simitt added the Team:Platforms Label for the Integrations - Platforms team label Feb 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 5, 2021
@andresrc andresrc added Team:Elastic-Agent Label for the Agent team and removed Team:Platforms Label for the Integrations - Platforms team labels Feb 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@urso
Copy link

urso commented Mar 3, 2021

In agent we already default to ECS.

How does the change to ECS in Beats by default change the log format?

If possible I would prefer if we do not change the defaults, as this might be a breaking change for users that already process/index Beats logs.

@simitt
Copy link
Contributor Author

simitt commented Mar 4, 2021

How does the change to ECS in Beats by default change the log format?

It would only make sense in combination with setting logging.json: true - so stdout logs would be in json;
The minimal ECS fields would be added to every log line.

I do not feel strongly about changing or not - up to you; just wanted to open, as originally you were asking for changing to default. Feel free to close the issue if the default should not be changed.

@ruflin
Copy link
Member

ruflin commented Apr 7, 2021

I filed an ECS logging issue for fleet-server: elastic/fleet-server#206 We should make it a requirement that any process run by the Elastic Agent MUST log in ECS.

@urso You mention above that with Elastic Agent we already default to ECS. Is this only for Elastic Agent logs or also all the process (beats)?

@faec faec assigned faec and unassigned urso Apr 4, 2022
@faec
Copy link
Contributor

faec commented Apr 4, 2022

Completed by @michel-laterman in #28573.

@faec faec closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

6 participants