Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the memory queue work with types other than publisher.Event #31307

Closed
faec opened this issue Apr 14, 2022 · 2 comments · Fixed by #31356 or #31699
Closed

Make the memory queue work with types other than publisher.Event #31307

faec opened this issue Apr 14, 2022 · 2 comments · Fixed by #31356 or #31699
Assignees
Labels
enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@faec
Copy link
Contributor

faec commented Apr 14, 2022

As we adapt the publisher pipeline to work with https://github.com/elastic/elastic-agent-shipper, we want new code to be able to work with established components like the memory queue. However, the memory queue is heavily tied to the specific data types in the current pipeline, particularly publisher.Event. (This dependency isn't used to access the type's contents, but rather to optimize heap layout.)

Modify the memory queue so that it handles essential metadata on input / output, but otherwise uses opaque pointers for its primary contents, allowing it to handle events ingested via a shipper RPC endpoint.

@faec faec added enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Apr 14, 2022
@faec faec self-assigned this Apr 14, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@faec
Copy link
Contributor Author

faec commented May 20, 2022

This auto-close was unintentional, the previous PR did not fully resolve the issue since it didn't expose the changes in the public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
2 participants