Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the queue's public API accept interface{} instead of publisher.Event #31699

Merged
merged 12 commits into from
May 26, 2022

Conversation

faec
Copy link
Contributor

@faec faec commented May 20, 2022

What does this PR do?

Finishes the refactor started in #31356, modifying the public queue API to accept and return interface{} pointers rather than publisher.Event, which will allow the new elastic shipper to use the libbeat queue for its internal storage.

Closes #31307

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels May 20, 2022
@faec faec requested a review from a team as a code owner May 20, 2022 15:44
@faec faec requested review from cmacknz and fearful-symmetry and removed request for a team May 20, 2022 15:44
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2022
@mergify mergify bot assigned faec May 20, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-23T21:13:09.070+0000

  • Duration: 75 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 22204
Skipped 1931
Total 24135

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@faec
Copy link
Contributor Author

faec commented May 23, 2022

This is ready for review now (the tests pass, locally at least)

Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, my LGTM is limited to the memqueue, since that's really the only part I understand, but it looks fine.

@faec faec merged commit a2b2b63 into elastic:main May 26, 2022
@faec faec deleted the shipper-queue branch May 26, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the memory queue work with types other than publisher.Event
4 participants