packetbeat/protos/http: don't panic when host is empty #36518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Packetbeat
Team:Security-External Integrations
8.11-candidate
backport-v8.10.0
botelastic
bot
added
needs_team
efd6
force-pushed
the
36497-packetbeat
branch
from
2d66265
to
6325774
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
efd6
force-pushed
the
36497-packetbeat
branch
2 times, most recently
from
ec069e5
to
7845723
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
force-pushed
the
36497-packetbeat
branch
from
7845723
to
e4c6d2e
Compare
Previously, extractHostHeader would panic if the host part of header was empty. Avoid this by using standard library functions to do splits and clean up IPv6 addresses. Add tests to confirm old behaviour and test to cover panic case.
efd6
force-pushed
the
36497-packetbeat
branch
from
e4c6d2e
to
54cd5fe
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Previously, extractHostHeader would panic if the host part of header was empty. Avoid this by using standard library functions to do splits and clean up IPv6 addresses. Add tests to confirm old behaviour and test to cover panic case. (cherry picked from commit 3d0cdb0)
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Previously, extractHostHeader would panic if the host part of header was empty. Avoid this by using standard library functions to do splits and clean up IPv6 addresses. Add tests to confirm old behaviour and test to cover panic case. (cherry picked from commit 3d0cdb0)
efd6
added a commit
that referenced
this pull request
Sep 6, 2023
… is empty (#36527) * packetbeat/protos/http: don't panic when host is empty (#36518) Previously, extractHostHeader would panic if the host part of header was empty. Avoid this by using standard library functions to do splits and clean up IPv6 addresses. Add tests to confirm old behaviour and test to cover panic case. (cherry picked from commit 3d0cdb0) * resolve semantic conflicts --------- Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com> Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6
added a commit
that referenced
this pull request
Sep 9, 2023
Previously, extractHostHeader would panic if the host part of header was empty. Avoid this by using standard library functions to do splits and clean up IPv6 addresses. Add tests to confirm old behaviour and test to cover panic case. (cherry picked from commit 3d0cdb0) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
Previously, extractHostHeader would panic if the host part of header was empty. Avoid this by using standard library functions to do splits and clean up IPv6 addresses. Add tests to confirm old behaviour and test to cover panic case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Previously, extractHostHeader would panic if the host part of header was empty. Avoid this by using standard library functions to do splits and clean up IPv6 addresses.
Add tests to confirm old behaviour and test to cover panic case.
Counter proposal to #36498.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs