Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Support CPU hotplug #6267

Closed
2 tasks
adriansr opened this issue Feb 2, 2018 · 3 comments
Closed
2 tasks

Meta: Support CPU hotplug #6267

adriansr opened this issue Feb 2, 2018 · 3 comments
Labels
discuss Issue needs further discussion. good first issue Indicates a good issue for first-time contributors libbeat meta Metricbeat Metricbeat Stalled Team:Integrations Label for the Integrations team

Comments

@adriansr
Copy link
Contributor

adriansr commented Feb 2, 2018

User reports that metricbeat needs to be restarted for the system module to pick up new CPUs hotplugged into the system. This is confirmed, system.cpu.cores does not update.

After reviewing the usage of runtime.NumCPU across beats, found out libbeat/metric/system/process/process.go also might calculate wrong CPU% if NumCPU changes. This should be reviewed.

To sum up:

  • Fix metricbeat cores metric to detect number of cores at runtime.
  • Review process CPU% calculation in libbeat for correctness if NumCPU changes.

FYI:
CPU hotplug in VirtualBox

@adriansr adriansr added discuss Issue needs further discussion. libbeat meta Metricbeat Metricbeat labels Feb 2, 2018
@tsg
Copy link
Contributor

tsg commented Feb 5, 2018

Is it a matter of reading the number of cores on every fetch? Or do we need to subscribe to something?

@adriansr
Copy link
Contributor Author

adriansr commented Feb 5, 2018

For the metricbeat issue, yes, it as simple as that.

@urso urso added good first issue Indicates a good issue for first-time contributors Team:Beats labels Dec 20, 2019
@andresrc andresrc added Team:Integrations Label for the Integrations team and removed Team:Beats labels Mar 6, 2020
@botelastic
Copy link

botelastic bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Feb 4, 2021
@botelastic botelastic bot closed this as completed Mar 6, 2021
@zube zube bot removed the [zube]: Done label Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. good first issue Indicates a good issue for first-time contributors libbeat meta Metricbeat Metricbeat Stalled Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

4 participants