Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[heartbeat] tls cert event data proposal #6300

Closed
Crazybus opened this issue Feb 6, 2018 · 1 comment · Fixed by #7545
Closed

[heartbeat] tls cert event data proposal #6300

Crazybus opened this issue Feb 6, 2018 · 1 comment · Fixed by #7545

Comments

@Crazybus
Copy link
Contributor

Crazybus commented Feb 6, 2018

In #3406 (comment) there was a suggestion for adding extra metadata including:

"tls": {
  "rtt": { "handshake": ... },
  "status": {
    "version": "TLS 3.0",
    "cipher": ...
  }
  "cert": {
    "expires": ...,
    ... // more certificate meta data?
  }
}

Specifically I am mostly interested in sending the tls.cert.expires key so that we can easily alert on certificates that will be expiring soon instead of the monitor failing once it has already expired.

Proposal

Ideally I would like to implement the following extra fields

  1. tls.cert.expires.notAfter: 2016-01-03T00:00:00.000Z
  2. tls.cert.expires.notBefore: 2019-02-06T00:00:00.000Z
  3. tls.status.version: TLS 3.0
  4. tls.status.cipher: ECDHE-RSA-AES256-GCM-SHA384

There are a lot of other fields that could be added however I see these being the most interesting when being combined with alerting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants