Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics to Performance Metricset on MSSQL Module #10011

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Jan 11, 2019

In this PR we add more metrics to Performance Metricset on MSSQL Module. The ones added could be considered the last ones that will be added for the sake of completeness in this Metricset.

Fields added:

  • logouts: Total number of logout operations started per second.
  • logins: Total number of logins started per second. This does not include pooled connections.
  • transactions: Total number of transactions in the instance. There's another metric that returns this value per database but it's omitted. We'll place it in a different Metricset.
  • active_temp_tables: Number of temporary tables/table variables in use.
  • connections_reset: Total number of logins started from the connection pool.
  • buffer.checkpoint_pages: Indicates the number of pages flushed to disk per second by a checkpoint or other operation that require all dirty pages to be flushed.
  • buffer.database_pages: Indicates the number of pages in the buffer pool with database content.
  • buffer.target_pages: Ideal number of pages in the buffer pool.

Fields modified. I found that few metrics were prefixed with buffer or has some relation with it (a total of 5) so I place them in the same object:

  • page_life_expectancy to buffer.page_life_expectancy
  • buffer_cache_hit to buffer.cache_hit

More things included in this PR:

  • New data.json generated file
  • Docs updated to describe new fields.
  • fields.yml modified and updated with the new structure of modified fields as well as new fields.
  • Integration test updated to check values of the new fields as well as the modified ones.
  • CHANGELOG entry.

@sayden sayden added enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Jan 11, 2019
@sayden sayden self-assigned this Jan 11, 2019
@sayden sayden requested a review from a team as a code owner January 11, 2019 11:25
@sayden sayden force-pushed the feature/xp/mb/add-more-fields-to-mssql-performance-metricset branch from b2dbd5e to d50ba59 Compare January 14, 2019 09:01
@sayden sayden merged commit 6f30560 into elastic:master Jan 14, 2019
@sayden sayden deleted the feature/xp/mb/add-more-fields-to-mssql-performance-metricset branch August 25, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants