Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functionbeat] Allow Kinesis to deploy using the CLI. #10116

Merged
merged 8 commits into from Jan 25, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Jan 16, 2019

This commit add support to publish a function that listen to a Kinesis
stream using the CLI.

Features:

  • Kinesis can now be defined in the YML.
  • AWS installer can now define a custom policies to be added to the lambda
    role.
  • Kinesis support TRIM_HORIZON and LATEST as the starting position
    strategy, AT_TIMESTAMP is currently not supported because the
    cloudformation API doesn't accept a TIMESTAMP when configuring the
    subscription.
  • Kinesis allow to configure the batch size.

@ph ph added in progress Pull request is currently in progress. Functionbeat labels Jan 16, 2019
This commit add support to publish a function that listen to a Kinesis
stream using the CLI.

Features:

- Kinesis can now defined in the YML.
- AWS installer can now define a custom policies to be added to the lambda
role.
- Kinesis support `TRIM_HORIZON` and `LATEST` as the starting position
strategy, `AT_TIMESTAMP` is currently not support because the
cloudformation API doesn't accept a TIMESTAMP when configuring the
subscription.
- Kinesis allow to configure the batch size.
@ph ph changed the title [WIP] Allow Kinesis to deploy using the CLI. Allow Kinesis to deploy using the CLI. Jan 17, 2019
@ph ph added review and removed in progress Pull request is currently in progress. labels Jan 17, 2019
@ph ph requested a review from kvch January 17, 2019 16:48
@ph ph mentioned this pull request Jan 17, 2019
29 tasks
@ph ph requested review from a team and removed request for a team January 18, 2019 18:30
@ph
Copy link
Contributor Author

ph commented Jan 18, 2019

@urso @kvch ready to be look at and reviewed.

@ph ph changed the title Allow Kinesis to deploy using the CLI. [functionbeat] Allow Kinesis to deploy using the CLI. Jan 18, 2019
Copy link

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvch please also have a look.

@ph
Copy link
Contributor Author

ph commented Jan 22, 2019

jenkins test this please

@ph ph added this to Needs review in Functionbeat Jan 22, 2019
Functionbeat automation moved this from Needs review to Reviewer approved Jan 23, 2019
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Jan 23, 2019
@ph
Copy link
Contributor Author

ph commented Jan 23, 2019

backport for 6.x

@ph
Copy link
Contributor Author

ph commented Jan 25, 2019

Jenkins test this please

@ph ph merged commit 5b4bb7f into elastic:master Jan 25, 2019
Functionbeat automation moved this from Reviewer approved to Done Jan 25, 2019
ph added a commit to ph/beats that referenced this pull request Jan 25, 2019
This commit add support to publish a function that listen to a Kinesis
stream using the CLI.

Features:

- Kinesis can now be defined in the YML.
- AWS installer can now define a custom policies to be added to the lambda
role.
- Kinesis support `TRIM_HORIZON` and `LATEST` as the starting position
strategy, `AT_TIMESTAMP` is currently not supported because the
cloudformation API doesn't accept a TIMESTAMP when configuring the
subscription.
- Kinesis allow to configure the batch size.

(cherry picked from commit 5b4bb7f)
@ph ph added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 25, 2019
ph added a commit that referenced this pull request Jan 26, 2019
**NOTES:**  This PR is based on top of #10116 

Correctly add the permissions to the lambda role when monitoring
SQS queue.

Fixes: #9152
ph added a commit that referenced this pull request Jan 29, 2019
This commit add support to publish a function that listen to a Kinesis
stream using the CLI.

Features:

- Kinesis can now be defined in the YML.
- AWS installer can now define a custom policies to be added to the lambda
role.
- Kinesis support `TRIM_HORIZON` and `LATEST` as the starting position
strategy, `AT_TIMESTAMP` is currently not supported because the
cloudformation API doesn't accept a TIMESTAMP when configuring the
subscription.
- Kinesis allow to configure the batch size.

(cherry picked from commit 5b4bb7f)
ph added a commit to ph/beats that referenced this pull request Jan 29, 2019
**NOTES:**  This PR is based on top of elastic#10116 

Correctly add the permissions to the lambda role when monitoring
SQS queue.

Fixes: elastic#9152

(cherry picked from commit dc963c4)
ph added a commit that referenced this pull request Jan 30, 2019
**NOTES:**  This PR is based on top of #10116 

Correctly add the permissions to the lambda role when monitoring
SQS queue.

Fixes: #9152

(cherry picked from commit dc963c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Functionbeat
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants