New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nats dashboard #10235
Add nats dashboard #10235
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@ruflin here is something we created. TBH I'm not confident enough about the beauty of the dashboard, but this is the overview we find meaningful for our purposes. |
Thanks, this is great. I'm good with the dashboards as is but still need to test it on my end. Some suggestions:
|
Nice! Will update it according to the suggestions! PS: @ruflin to make your life easier with manual testing: |
Hi @ChrsMark 🙂 Amazing contribution, dashboards are very important for each module. I think the dashboard wasn't exported correctly. I get this when trying to open it: Also, I cannot open each visualization. It just hangs when I clicked them, first time I see something similar. Can you tell us how did you export the dashboard? Thanks! |
Hmm, this is an error on my end. I had the visualizations already in Kibana from previous step so when I reloaded the dashboard with Let me tune the visualization IDs. @sayden, I followed the steps below:
Is this the normal workflow? |
Finally I made it work smoothly with: Change regarding fields (conversion to bytes) will be addressed on another commit. (cc: @skatsaounis, @MichaelKatsoulis ) |
@ChrsMark this is looking great 🙂 As an extra suggestion, I'd propose to use more line/area graphs and less gauges and numbers, for example for the number of consumers we could have a graph like the one for subscriptions. Also, for the volume of messages we could have graphs with two scales, one for number of messages and another one for its size in bytes, and something similar for cpu usage. I think gauges are great for dashboards that are not usually operated, like the ones that can be seen in a screen in the wall 🙂 But when operating or investigating an incidence in an specific period of time I find graphs with the evolution of the values much more useful. |
34c69ec
to
3e8bafb
Compare
As #10249 was merged this will require a rename of the dir |
Awesome @ChrsMark The chart can be loaded already. As a general workflow, a user will load the dashboard by doing the setup with Few minor things left that I didn't see/realized before (sorry):
Finally, but I'm not fully sure why, some index patterns are missing. I don't have any good suggestion:
@ruflin do you have any idea of why some of the index pattern fields have not been uploaded? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks very good. Left some comments
To fix the conflicts you'll need to rebase over master and then push the changes in those files after running |
Hi all, I have made the rebase locally and also worked on your comments. Tomorrow I am going to push a new patch which also contains changes to some field types (eg. long instead of integer etc) based on NATS output. |
Signed-off-by: Chris <chrismarkou92@gmail.com> Co-Authored-By: Stamatis Katsaounis <katsaouniss@gmail.com> Co-Authored-By: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Signed-off-by: Chris <chrismarkou92@gmail.com>
Signed-off-by: Chris <chrismarkou92@gmail.com>
Signed-off-by: Chris <chrismarkou92@gmail.com>
e06c88f
to
4c529bd
Compare
Signed-off-by: Stamatis Katsaounis <katsaouniss@gmail.com> Co-Authored-By: Christos Markou <chrismarkou92@gmail.com> Co-Authored-By: Michael Katsoulis <michaelkatsoulis88@gmail.com>
4c529bd
to
97459e4
Compare
@ruflin Hi Travis is green. Can you trigger Jenkins as well? :) |
jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and seems to work as expected. Unfortunately my graphs don't look as nice as I don't that nice data ;-)
@skatsaounis Any chance you could open a follow up PR to the docs with the above dashboard images so it shows up here? https://www.elastic.co/guide/en/beats/metricbeat/master/metricbeat-module-nats.html Would be nice to show to users in advance what kind of dashboard they get. |
Hi @ruflin. Thank you for merging this PR. I am going to update the docs; no problem at all :) I will mention you to the new PR when it will be ready. |
This PR adds an overview dashboard for
nats
module as proposed on #10071.Co-Authored-By: Stamatis Katsaounis katsaouniss@gmail.com
Co-Authored-By: Michael Katsoulis michaelkatsoulis88@gmail.com