Update and add missing descriptions to ETCD module #10592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10239 and adds some missing descriptions.
I'm not sure if this module needs a bit of polishing. On one side we are using fields like
average
,current
orstandardDeviation
that maybe should be omitted leaving onlycurrent
. On the other side we have fields likeetcd.self.recv.appendrequest.count
that maybe should be calledetcd.self.received.append_requests
or aetcd.self.recv.pkgrate
that maybe should beetcd.self.received.packages_rate.per_sec
oretcd.store.compareanddelete.fail
(etcd.store.compare_and_delete.fail
)By the way, I also saw that
data.json
files are not complete because the module uses a compose configuration without clustering. I'm not sure if this can just be updated by using a manually created cluster so that it shows all possible fields or it should be created in CI (or matched in the CI). For example, in theleader
metricset we have this data.json file but we might have this: