Collect license expiry date fields as well

[ycombinator]

This PR teaches the elasticsearch.cluster_stats metricset (x-pack code path) to collect and index the license expiration fields, expiry_date and expiry_date_in_millis as well.

Testing this PR

Basic license

1. Start Elasticsearch with a Basic license.
2. Delete .monitoring-es-* indices to start with a clean slate (making it easier to test).

   DELETE .monitoring-es-*
   

3. Turn on Elasticsearch monitoring via the native collection method.
4. Wait ~15 seconds for documents to be indexed into .monitoring-es-*.
5. Check the value of the license field indexed into a .monitoring-es-* document with type:cluster_stats. In particular, note that it is missing the expiry_date and expiry_date_in_millis sub-fields.

   POST .monitoring-es-7-*/_search?filter_path=**.license
   {
     "query": {
       "term": {
         "type": "cluster_stats"
       }
     }
   }
   

6. Turn off Elasticsearch native collection.

   PUT _cluster/settings
   {
     "transient": {
       "xpack.monitoring.elasticsearch.collection.enabled": false
     }
   }
   

7. Delete .monitoring-es-* indices to start with a clean slate (making it easier to test).

   DELETE .monitoring-es-*
   

8. Build Metricbeat with this PR.

   cd $GOPATH/src/github.com/elastic/beats/metricbeat
   mage build
   

9. Enable Elasticsearch collection via Metricbeat.

   ./metricbeat modules enable elasticsearch-xpack
   

10. Start Metricbeat

    ./metricbeat
    

11. Wait ~15 seconds for documents to be indexed into .monitoring-es-*.
12. Check the value of the license field indexed into a .monitoring-es-* document with type:cluster_stats. In particular, verify that it is missing the expiry_date and expiry_date_in_millis sub-fields.

POST .monitoring-es-7-*/_search?filter_path=**.license
{
  "query": {
    "term": {
      "type": "cluster_stats"
    }
  }
}

Trial license

1. Start Elasticsearch with a Trial license. If you started with a Basic license, you can upgrade to Trial via the Kibana License Management UI.
2. Delete .monitoring-es-* indices to start with a clean slate (making it easier to test).

   DELETE .monitoring-es-*
   

3. Turn on Elasticsearch monitoring via the native collection method.
4. Wait ~15 seconds for documents to be indexed into .monitoring-es-*.
5. Check the value of the license field indexed into a .monitoring-es-* document with type:cluster_stats. In particular, note that it includes the expiry_date and expiry_date_in_millis sub-fields.

   POST .monitoring-es-7-*/_search?filter_path=**.license
   {
     "query": {
       "term": {
         "type": "cluster_stats"
       }
     }
   }
   

6. Turn off Elasticsearch native collection.

   PUT _cluster/settings
   {
     "transient": {
       "xpack.monitoring.elasticsearch.collection.enabled": false
     }
   }
   

7. Delete .monitoring-es-* indices to start with a clean slate (making it easier to test).

   DELETE .monitoring-es-*
   

8. Build Metricbeat with this PR.

   cd $GOPATH/src/github.com/elastic/beats/metricbeat
   mage build
   

9. Enable Elasticsearch collection via Metricbeat.

   ./metricbeat modules enable elasticsearch-xpack
   

10. Start Metricbeat

    ./metricbeat
    

11. Wait ~15 seconds for documents to be indexed into .monitoring-es-*.
12. Check the value of the license field indexed into a .monitoring-es-* document with type:cluster_stats. In particular, verify that it includes the expiry_date and expiry_date_in_millis sub-fields.

POST .monitoring-es-7-*/_search?filter_path=**.license
{
  "query": {
    "term": {
      "type": "cluster_stats"
    }
  }
}

[elasticmachine]

Pinging @elastic/stack-monitoring

[cachedout]

@ycombinator Do you have any recommendations on how to test this?

[ycombinator]

Do you have any recommendations on how to test this?

Unfortunately there's no easy way to test this PR until elastic/elasticsearch#40872 is resolved first.

[ycombinator]

jenkins, test this

[cachedout]

LGTM

[ycombinator]

@cachedout I've updated this PR per @tvernum's comment here: elastic/elasticsearch#40872 (comment). This is ready for review now. Thanks!

[ycombinator]

jenkins, test this

[cachedout]

👍

[ycombinator]

jenkins, test this