[libbeat] Add output.elasticsearch.proxy_disable flag #12243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
approved these changes
May 23, 2019
| // I'm not entirely satisfied with this approach, but it seems by nature of | ||
| // golang's proxy handling that we can't do better without a multi-machine | ||
| // integration test. | ||
| func TestProxyDisableOverridesProxySettings(t *testing.T) { |
|
@faec Can you add a changelog entry? |
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
Add a `proxy_disable` output flag that can disable output proxy settings even if they are set in environment variables (HTTP_PROXY, etc., as specified in [the Golang http package](https://golang.org/pkg/net/http/#ProxyFromEnvironment)). This was requested because specifying a blank Proxy field will still fall back to the environment variables, which may not be easily modified by the caller, especially on windows. Setting proxy_disable can bypass all proxies with only a configuration change. Resolves elastic#11713.
|
starting with version 7.3.0 we are getting connection problem behind proxy no matter what the value is for proxy_disable. Same config works with 7.2.1 |
This change was already in 7.2 (and typically has no effect), so if you're having proxy trouble upgrading from 7.2.1 to 7.3.0 it's probably caused by something else. You can try asking about your configuration in our discussion forums, or if you already have enough context to provide a bug report you can submit an issue. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag that can disable output proxy settings even if they are set in environment variables (HTTP_PROXY, etc., as specified in the Golang http package). This was requested because specifying a blank Proxy field will still fall back to the environment variables, which may not be easily modified by the caller, especially on windows. Setting proxy_disable can bypass all proxies with only a configuration change.
Resolves #11713.