Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable AWS endpoint #12369

Merged
merged 5 commits into from
May 31, 2019
Merged

Configurable AWS endpoint #12369

merged 5 commits into from
May 31, 2019

Conversation

kvch
Copy link
Contributor

@kvch kvch commented May 30, 2019

New option is added to the configuration to support custom AWS endpoints named endpoint.

# Configure which S3 endpoint should we use.
functionbeat.provider.aws.endpoint: "s3.amazonaws.com"

Closes #12368

@kvch kvch requested a review from ph May 30, 2019 14:52
kaiyan-sheng
kaiyan-sheng approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong 😄 With this change, functionbeat.provider.aws.endpoint can be s3.amazonaws.com or s3.aws-region.amazonaws.com, which will support both S3 URLs.

@kvch
Copy link
Contributor Author

kvch commented May 30, 2019 •
edited
Loading

It is true. However, it is an invalid setting. Thinking about it for a while, I am adding a few sentences to the documentation to make sure users are setting it correctly. Thank you for pointing it out! My bad. It works.

@kvch
Copy link
Contributor Author

kvch commented May 31, 2019

jenkins test this

@kvch
Copy link
Contributor Author

kvch commented May 31, 2019

Failing tests are unrelated.

@kvch kvch merged commit 4319c31 into elastic:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@ph ph Awaiting requested review from ph

Assignees
No one assigned
Labels
Functionbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Functionbeat] AWS endpoint configurable
2 participants
@kvch @kaiyan-sheng