[metricbeat] Add system/entropy metricset #12450
Conversation
fearful-symmetry
added
enhancement
Metricbeat
| MetricSetFields: common.MapStr{ | ||
| "entropy": common.MapStr{ | ||
| "available_bits": entropy, | ||
| "pct": float64(entropy) / float64(4096), |
There was a problem hiding this comment.
I think this max of 4096 is hardcoded in linux, can you confirm?
There was a problem hiding this comment.
Is it the value available in /proc/sys/kernel/random/poolsize? Should we get it from there in case it changes somewhere at some moment?
fearful-symmetry
force-pushed
the
entropy-metricset
branch
from
beb2aad
to
1611337
Compare
|
@exekias added the changelog, and (hopefully) fixed the fields. |
| }, | ||
| "system": { | ||
| "entropy": { | ||
| "entropy": { |
There was a problem hiding this comment.
Do we want this double entropy level?
There was a problem hiding this comment.
ups, I missed this when we talked about object vs group, +1 to one level only
| MetricSetFields: common.MapStr{ | ||
| "entropy": common.MapStr{ | ||
| "available_bits": entropy, | ||
| "pct": float64(entropy) / float64(4096), |
There was a problem hiding this comment.
Is it the value available in /proc/sys/kernel/random/poolsize? Should we get it from there in case it changes somewhere at some moment?
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
There was a problem hiding this comment.
I guess we should exclude this metricset from non-linux builds.
|
Yah, @jsoriano I was sorta ambivalent about |
|
Updated a bunch of things, and ended up using the
|
|
Okay, latest commit should fix the field formatting issues, and the build issues. |
|
Oops, forgot to change the tests after I fixed the mapping. |
fearful-symmetry
requested review from
a team,
exekias,
sayden,
kaiyan-sheng and
jsoriano
and removed request for
kaiyan-sheng
|
Okay, that should be the last of the bugfixes and updates. |
This PR adds a system/entropy metricset, which monitors and reports the state of
/proc/sys/kernel/random/entropy_availMany other monitoring solutions have this, including node_exporter and netdata.This is a (comparatively) small metricset, as there really isn't a lot going on. Most of the other files in
randomaren't particularly interesting as far as monitoring, although y'all are free to disagree if you think we should add others. *bsd also generates entropy differently, meaning there's no equivalent toentropy_avail, and most of the metrics exposed bykern.randomI didn't think were particularly interesting, although, again, if we decide they're valuable I can add them.Because the full path (
/proc/sys/kernel/random/entropy_avail) is a tad long-winded, I wasn't sure if we wanted to add a custom config option for the metricset to specify a path toentropy_avail, so for now I'm piggy-backing off of the systemhostfsoption.