[Metricbeat] Add nil pointer checks for docker NetworkSettings #12628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
Metricbeat
exekias
reviewed
Jun 21, 2019
|
I always forget the changelog... |
kaiyan-sheng
approved these changes
Jun 21, 2019
exekias
reviewed
Jun 21, 2019
Co-Authored-By: Carlos Pérez-Aradros Herce <exekias@gmail.com>
|
Not sure what's up with the CI failure. Looks like a fields.yml issue, but those haven't been touched? |
exekias
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was @exekias and I's idea, as a quick hotfix to deal with #12524.
See also vmware/vic#8564
We decided at this point we don't need full support for VIC, but It can't hurt to add more nil pointer checks.
I'm still trying to figure out to what degree this would impact other parts of the docker module. I don't have a lot of experience setting up vSphere, which isn't helping.