Fix module config defaults in light modules #12674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
bug
review
Metricbeat
Use common base module builder when creating the base module for light modules, so same defaults are set and same checks are executed. Without this change there are errors if values that have defaults like `period` are not set.
jsoriano
force-pushed
the
fix-lightmetricset-defaults
branch
from
09bc860
to
308be27
Compare
|
jenkins, test this again please |
exekias
approved these changes
Jun 27, 2019
I have seen that I already added a test that should have detected this, but it was broken, I pushed a fix for it here. |
exekias
approved these changes
Jun 27, 2019
kaiyan-sheng
approved these changes
Jun 27, 2019
jsoriano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common base module builder when creating the base module for light
modules, so same defaults are set and same checks are executed. Without
this change there are errors if values that have defaults like
periodare not set.
Related to #12270