Separate AWS module config file example into metricset specific #12701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
Team:Integrations
|
jenkins, test this please |
|
@jsoriano Thanks for your suggestion on making this change! Please let me know if this looks better. |
|
Maybe I'm confused, but don't we have |
Ahh I didn't realize there is this file. I will add it, thanks!! |
jsoriano
reviewed
Jun 28, 2019
There was a problem hiding this comment.
Thanks for following with this, it is looking better. I would explain with more detail at least the cloudwatch example, so users can create their own configurations more easily.
Maybe @Titch990 can give some ideas too for these examples.
kaiyan-sheng
added
[zube]: Ready
[zube]: In Progress
and removed
[zube]: Inbox
[zube]: Ready
labels
jsoriano
reviewed
Jul 10, 2019
Co-Authored-By: Jaime Soriano Pastor <jaime.soriano@elastic.co>
jsoriano
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address: #12480 (comment)
The configuration example in config.yml is way too long and not user friendly. So we decide to make config.yml short and put configuration example into each metricset.