Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator] add a choices var to generator.py #12773

Merged

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jul 3, 2019

See #12765 for the bug

Adding a choices var to the parser argument seemed like the most elegant and most pythonic way to fix this. We might not want to add error handling to os.walk, since presumably it ignores all errors for a reason. I also imagine this script won't last too much longer, as we need to migrate all this to mage anyway.

@fearful-symmetry fearful-symmetry added :Generator Related to code generators for building custom Beats or modules. Team:Integrations Label for the Integrations team labels Jul 3, 2019
@fearful-symmetry fearful-symmetry requested review from a team July 3, 2019 17:37
@fearful-symmetry fearful-symmetry self-assigned this Jul 3, 2019
@fearful-symmetry fearful-symmetry merged commit 3ed2c5c into elastic:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug :Generator Related to code generators for building custom Beats or modules. Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants