[metricbeat]update apiserver metrics #12922
Conversation
odacremolbap
added
Metricbeat
odacremolbap
added
review
and removed
in progress
| "apiserver_request_duration_seconds": prometheus.Metric("request.duration.us", prometheus.OpMultiplyBuckets(1000000)), | ||
| "apiserver_request_latencies": prometheus.Metric("request.latency"), | ||
| "apiserver_request_total": prometheus.Metric("request.count"), | ||
| "apiserver_request_count": prometheus.Metric("request.beforev14.count"), |
There was a problem hiding this comment.
Is there any version where both apiserver_request_total and apiserver_request_count cohexists? If the answer is no you could just use "request.count" in both cases
There was a problem hiding this comment.
unfortunately both exists at the same metric resource.
There are way better way dealing with this than this one with some revamping of the prometheus package, but that is far out of scope of this PR
There was a problem hiding this comment.
Thanks for the explanation, one more question. Are the values/types under these different?
There was a problem hiding this comment.
same everything but for an added label at the non deprecated apiserver_request_total for dry runs
| // to metrics retrieval in general, so mappings, retrieved metrics, ... can be | ||
| // modified on events. Current design is limiting | ||
| if ok, _ := event.HasKey("request.beforev14.count"); ok { | ||
| if ok, _ := event.HasKey("request.count"); !ok { |
There was a problem hiding this comment.
Not sure if I understood this right, but if the old count metric has different labels than the new one.. i guess they should never end up in the same document? that would mean this condition is always satisfied
There was a problem hiding this comment.
so true, thanks for spotting that
odacremolbap
added
in progress
odacremolbap
added
review
and removed
in progress
|
thank you for the extra effort to maintain bwc! |
As stated here, updating metrics and adding new ones
apiserver_request_totalif it is informed,apiserver_request_countif not, using the same event pathrequest.countapiserver_request_duration_secondsandapiserver_request_latencieswill be retrieved, although only the first should be used, the later will allow current dashboard to work.