Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Export Host fields to gob encoder #12940

Merged
merged 2 commits into from Jul 23, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Jul 17, 2019

In the system/host dataset, the fields of the Host struct are not exported, and so cannot be picked up by gob. This prevents it being written to disk to detect changes between restarts, and causes error messages like:

2019-07-17T11:44:37.842+0100 ERROR [system] host/host.go:210 error encoding host information: gob: type host.Host has no exported fields

This PR changes the fields to be exported.

Also mentioned in this discuss thread.

@cwurm cwurm added bug review needs_backport PR is waiting to be backported to other branches. Auditbeat SecOps labels Jul 17, 2019
@cwurm cwurm requested a review from a team as a code owner July 17, 2019 10:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

@cwurm cwurm merged commit 83f18e9 into elastic:master Jul 23, 2019
@cwurm cwurm deleted the host_gob_encoding branch July 23, 2019 14:19
cwurm pushed a commit to cwurm/beats that referenced this pull request Jul 23, 2019
In the `system/host` dataset, the fields of the `Host` struct are not exported, and so cannot be picked up by `gob`. This prevents it from being written to disk to detect changes between restarts and causes error messages. This changes the fields to be exported.

(cherry picked from commit 83f18e9)
@cwurm cwurm added v7.3.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 23, 2019
@cwurm cwurm added the v6.8.2 label Jul 23, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request Jul 23, 2019
In the `system/host` dataset, the fields of the `Host` struct are not exported, and so cannot be picked up by `gob`. This prevents it from being written to disk to detect changes between restarts and causes error messages. This changes the fields to be exported.

(cherry picked from commit 83f18e9)
cwurm pushed a commit that referenced this pull request Jul 24, 2019
In the `system/host` dataset, the fields of the `Host` struct are not exported, and so cannot be picked up by `gob`. This prevents it from being written to disk to detect changes between restarts and causes error messages. This changes the fields to be exported.

(cherry picked from commit 83f18e9)
cwurm pushed a commit that referenced this pull request Jul 24, 2019
In the `system/host` dataset, the fields of the `Host` struct are not exported, and so cannot be picked up by `gob`. This prevents it from being written to disk to detect changes between restarts and causes error messages. This changes the fields to be exported.

(cherry picked from commit 83f18e9)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
elastic#13032)

In the `system/host` dataset, the fields of the `Host` struct are not exported, and so cannot be picked up by `gob`. This prevents it from being written to disk to detect changes between restarts and causes error messages. This changes the fields to be exported.

(cherry picked from commit c476be4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants