[Filebeat] Fix filebeat autodiscover fileset hint for container input #13296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Hi Guys, is there anyone reviewing this? It looks like a bug. |
|
@pragkent yes, I have your PRs in my pipeline for today or tomorrow 🙂 thanks a lot for them! |
|
@jsoriano Thank you : ). |
jsoriano
added
needs_backport
|
ok to test |
jsoriano
approved these changes
Aug 30, 2019
jsoriano
approved these changes
Aug 30, 2019
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
…elastic#13296) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 658772a)
jsoriano
removed
the
needs_backport
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
…elastic#13296) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 658772a)
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
…elastic#13296) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 658772a)
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
…elastic#13296) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 658772a)
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Aug 30, 2019
…elastic#13296) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 658772a)
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2019
…#13296) (#13447) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes #12718 (cherry picked from commit 658772a) Co-authored-by: Kent Wang <pragkent@gmail.com>
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2019
…#13296) (#13449) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes #12718 (cherry picked from commit 658772a) Co-authored-by: Kent Wang <pragkent@gmail.com>
jsoriano
added a commit
that referenced
this pull request
Aug 30, 2019
…#13296) (#13451) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes #12718 (cherry picked from commit 658772a) Co-authored-by: Kent Wang <pragkent@gmail.com>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#13296) (elastic#13451) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 8c34c2b) Co-authored-by: Kent Wang <pragkent@gmail.com>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#13296) (elastic#13447) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 8c34c2b) Co-authored-by: Kent Wang <pragkent@gmail.com>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#13296) (elastic#13449) Currently, autodiscover hint assumes that input type is docker. Since docker input is deprecated in 7.2.0, container input should be supported. So we need to set `stream` or `containers.stream` based on input type. Closes elastic#12718 (cherry picked from commit 8c34c2b) Co-authored-by: Kent Wang <pragkent@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, autodiscover hint assumes that input type is docker.
Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set
streamorcontainers.streambased on input type.Closes #12718