Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Fix filebeat autodiscover fileset hint for container input #13296

Merged
merged 4 commits into from Aug 30, 2019

Conversation

@pragkent
Copy link
Contributor

commented Aug 21, 2019

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set stream or containers.stream based on input type.

Closes #12718

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@pragkent

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Hi Guys, is there anyone reviewing this? It looks like a bug.

@jsoriano

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@pragkent yes, I have your PRs in my pipeline for today or tomorrow 🙂 thanks a lot for them!

@pragkent

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@jsoriano Thank you : ).
Just to check how is it going.

Copy link
Member

left a comment

@pragkent good catch, this looks good to me, could you add a changelog entry for the fix? Thanks a lot!

@jsoriano

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

ok to test

pragkent and others added 2 commits Aug 30, 2019
@jsoriano jsoriano merged commit 658772a into elastic:master Aug 30, 2019
4 checks passed
4 checks passed
CLA All commits in pull request signed
Details
Hound No violations found. Woof!
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zube zube bot added [zube]: Done and removed [zube]: In Review labels Aug 30, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
…elastic#13296)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes elastic#12718

(cherry picked from commit 658772a)
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
…elastic#13296)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes elastic#12718

(cherry picked from commit 658772a)
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
…elastic#13296)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes elastic#12718

(cherry picked from commit 658772a)
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
…elastic#13296)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes elastic#12718

(cherry picked from commit 658772a)
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 30, 2019
…elastic#13296)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes elastic#12718

(cherry picked from commit 658772a)
jsoriano added a commit that referenced this pull request Aug 30, 2019
…#13296) (#13447)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes #12718

(cherry picked from commit 658772a)

Co-authored-by: Kent Wang <pragkent@gmail.com>
jsoriano added a commit that referenced this pull request Aug 30, 2019
…#13296) (#13449)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes #12718

(cherry picked from commit 658772a)

Co-authored-by: Kent Wang <pragkent@gmail.com>
jsoriano added a commit that referenced this pull request Aug 30, 2019
…#13296) (#13451)

Currently, autodiscover hint assumes that input type is docker.

Since docker input is deprecated in 7.2.0, container input should be supported.
So we need to set `stream` or `containers.stream` based on input type.

Closes #12718

(cherry picked from commit 658772a)

Co-authored-by: Kent Wang <pragkent@gmail.com>
@andresrc andresrc removed the [zube]: Done label Sep 3, 2019
@pragkent pragkent deleted the pragkent:fix-hint-fileset branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.