Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dashboards index pattern #13303

Merged
merged 8 commits into from Aug 22, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 21, 2019

If a dashboard is created using an index pattern manually created,
it can contain incorrect references, check for index patterns to avoid
this mistake.

Fix #13300

@jsoriano jsoriano added review :Dashboards Team:Integrations Label for the Integrations team labels Aug 21, 2019
@jsoriano jsoriano requested a review from a team as a code owner August 21, 2019 12:20
@jsoriano jsoriano self-assigned this Aug 21, 2019
@jsoriano
Copy link
Member Author

jenkins, test this again

Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Once you fix the CHANGELOG incorrect entry

@jsoriano
Copy link
Member Author

I found another place where wrong index patterns can appear, and we had a couple of dashboards affected in Filebeat, @kaiyan-sheng or @sayden could you take another look?

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing aws s3 filebeat dashboard. I tested and it works.

@jsoriano
Copy link
Member Author

@kaiyan-sheng thanks for testing!

@jsoriano jsoriano merged commit bffe7aa into elastic:master Aug 22, 2019
@jsoriano jsoriano deleted the check-dashboards-index-pattern branch August 22, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Dashboards review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Redis keys dashboard references non-existing index
3 participants