Add registered_domain processor #13326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem |
houndci-bot
reviewed
Aug 22, 2019
adriansr
approved these changes
Aug 23, 2019
@adriansr Yeah, the discussion around the name |
webmat
approved these changes
Aug 23, 2019
The `registered_domain` processor reads a field containing a hostname and then writes the "registered domain" contained in the hostname to the target field. For example, given `www.google.co.uk` the processor would output `google.co.uk`. In other words the "registered domain" is the effective top-level domain (`co.uk`) plus one level (`google`). This can be used to populate the ECS `dns.question.registered_domain` field.
andrewkroh
force-pushed
the
feature/libbeat/registered-domain-processor
branch
from
fa85160
to
dcc2204
Compare
|
@adriansr I agree with you that the name isn't great. I chose it to match the ECS field name which went through much debate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
registered_domainprocessor reads a field containing a hostname and thenwrites the "registered domain" contained in the hostname to the target field.
For example, given
www.google.co.ukthe processor would outputgoogle.co.uk.In other words the "registered domain" is the effective top-level domain
(
co.uk) plus one level (google).This can be used to populate the ECS
dns.question.registered_domainfield.