Enable Logstash output #13345
Merged
Enable Logstash output #13345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 26, 2019
houndci-bot
reviewed
Aug 26, 2019
houndci-bot
reviewed
Aug 26, 2019
houndci-bot
reviewed
Aug 26, 2019
ph
suggested changes
Aug 26, 2019
| Check: isElasticsearch, | ||
| Config: esOverrides, | ||
| }, | ||
| } |
There was a problem hiding this comment.
neat I haven't thought about doing it this way.
| @@ -122,7 +132,7 @@ func Read(out interface{}, path string) error { | |||
| // Load reads the configuration from a YAML file structure. If path is empty | |||
| // this method reads from the configuration file specified by the '-c' command | |||
| // line flag. | |||
| func Load(path string, beatOverrides *common.Config) (*common.Config, error) { | |||
| func Load(path string, beatOverrides *common.Config, conditionalOverrides []ConditionalOverride) (*common.Config, error) { | |||
| var config *common.Config | |||
There was a problem hiding this comment.
Could we merge BeatsOverrides with conditionalsOverrides, the only difference between the two is that one of them should be applied all the time. No?
There was a problem hiding this comment.
Yes, after taking a walk I realized that they could be in the same list. :D
|
Also there is a few hound comments that appear valid to me. |
|
Failing tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Logstash output for Functionbeat. The option
pipeliningis set to 0 to send events synchronously.From now on configuration overrides also depend on the selected output. So I introduced a new setting
cfgfile.ConditionalOverridefor Beats. This lets developers define a function which is if evaluated to true, the corresponding config overrides are applied.Closes #11757