Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panic recover to JS script processor #13746

Conversation

andrewkroh
Copy link
Member

To help debug panics in the script processor add a recover() statement that will log the event being processed.

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably worth a changelog entry?

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree on the need for a CHANGELOG entry

To help debug panics in the script processor add a `recover()` statement that will log the event being processed.
@andrewkroh andrewkroh force-pushed the feature/js-processor-panic-recover-logging branch from 78d2142 to 69652da Compare September 24, 2019 13:50
@andrewkroh andrewkroh merged commit 256e112 into elastic:master Sep 24, 2019
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Oct 3, 2019
To help debug panics in the script processor add a `recover()` statement that will log the event being processed.

(cherry picked from commit 256e112)
andrewkroh added a commit that referenced this pull request Oct 7, 2019
To help debug panics in the script processor add a `recover()` statement that will log the event being processed.

(cherry picked from commit 256e112)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
To help debug panics in the script processor add a `recover()` statement that will log the event being processed.

(cherry picked from commit e2e641e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants