Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state field for connection metricset from RabbitMQ module (#13697) #WIP #13981

Merged
merged 1 commit into from Nov 4, 2019
Merged

Conversation

amandahla
Copy link
Contributor

Add state field for connectino metricset. Still needs to test in real environment.

@amandahla amandahla requested a review from a team as a code owner October 9, 2019 12:49
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@exekias exekias added Team:Integrations Label for the Integrations team enhancement Metricbeat Metricbeat module labels Oct 10, 2019
@exekias
Copy link
Contributor

exekias commented Oct 10, 2019

Thank you for opening this @amandahla! Can you please update fields.yml for connection metricset to accomodate this new field?

@andresrc
Copy link
Contributor

Fixes #13697

@odacremolbap
Copy link
Contributor

Hi @amandahla

this looks good, but I noticed some indentation at golden/JSON files that lead me to think you are manually editing them.

Would you mind to:

cd GOPATH/src/github.com/elastic/beats/metricbeat/module/rabbitmq/connection
go test  ./... -generate

that command should generate both JSON files with correct indentation.

@amandahla
Copy link
Contributor Author

@odacremolbap done! :-)

Copy link
Contributor

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @amandahla
please, proceed to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat module Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants