Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] respect overwrite config in setup #14741

Merged
merged 7 commits into from
Nov 27, 2019
Merged

[ILM] respect overwrite config in setup #14741

merged 7 commits into from
Nov 27, 2019

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Nov 25, 2019

Respect setup.ilm.overwrite configuration when running setup cmd. Print warning if overwrite is disabled on setup cmd.

fixes #14735

@simitt
[ILM] respect overwrite config in setup
9ea8a52 
Respect `setup.ilm.overwrite` configuration when running setup
cmd. Print warning if overwrite is disabled on setup cmd.

fixes elastic#14735
@simitt simitt requested a review from urso November 25, 2019 11:20
urso
urso reviewed Nov 25, 2019
View reviewed changes
libbeat/idxmgmt/ilm/ilm.go Outdated Show resolved Hide resolved
@simitt
Copy link
Contributor Author

simitt commented Nov 26, 2019

Same tests failing as in master.

urso
urso approved these changes Nov 26, 2019
View reviewed changes
Copy link

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what CI thinks.

@simitt simitt merged commit b15fa53 into elastic:master Nov 27, 2019
simitt added a commit to simitt/beats that referenced this pull request Nov 27, 2019
@simitt
[ILM] respect overwrite config in setup (elastic#14741)
7e8a688 
Respect `setup.ilm.overwrite` configuration when running setup
cmd. Print warning if overwrite is disabled on setup cmd.

fixes elastic#14735
@simitt simitt mentioned this pull request Nov 27, 2019
Merged
simitt added a commit that referenced this pull request Nov 28, 2019
@simitt
[ILM] respect overwrite config in setup (#14741) (#14819)
dbbceff 
Respect `setup.ilm.overwrite` configuration when running setup
cmd. Print warning if overwrite is disabled on setup cmd.

fixes #14735
@ycombinator ycombinator mentioned this pull request Dec 11, 2019
Closed
ycombinator pushed a commit to ycombinator/beats that referenced this pull request Dec 11, 2019
@simitt @ycombinator
[ILM] respect overwrite config in setup (elastic#14741)
29fbbe3 
Respect `setup.ilm.overwrite` configuration when running setup
cmd. Print warning if overwrite is disabled on setup cmd.

fixes elastic#14735
@ycombinator ycombinator mentioned this pull request Dec 11, 2019
Closed
@simitt simitt added Team:apm APM Server team issues/PRs test-plan Add this PR to be manual test plan v7.6.0 Team:Beats labels Jan 20, 2020
@urso
Copy link

urso commented Jan 22, 2020

Tested:

  • ILM policy is installed if policy name does not exist. OK
  • modified ILM policy is not overwritten if name already exists. OK
  • ILM policy is always overwritten if setup.ilm.overwrite is true. OK
  • Check if reference configs miss any updates. OK
  • Check if setup help output is missing updates. OK
  • Check if documentation needs to be updated. OK
  • Check that some information is logged/printed if setup.ilm.overwrite is false on <beatname> setup. OK

@urso urso added the test-plan-ok This PR passed manual testing label Jan 22, 2020
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
@simitt simitt deleted the 14735-ilm-setup branch August 4, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@urso urso urso approved these changes

Assignees

@urso urso

Labels
breaking change enhancement Team:apm APM Server team issues/PRs Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change setup behavior to respect ilm.overwrite setting
4 participants
@simitt @urso @houndci-bot @andresrc