Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSLconfig in input.yml for Filebeat httpjson input in the MISP module #14767

Merged
merged 6 commits into from
Dec 10, 2019
Merged

Fix SSLconfig in input.yml for Filebeat httpjson input in the MISP module #14767

merged 6 commits into from
Dec 10, 2019

Conversation

alakahakai
Copy link

No description provided.

@alakahakai alakahakai requested a review from a team as a code owner November 25, 2019 21:37
@alakahakai alakahakai changed the title Add ssl config to input.yml for Filebeat httpjson input in the MISP module Fix ssl config in input.yml for Filebeat httpjson input in the MISP module Nov 25, 2019
mtojek
mtojek reviewed Nov 26, 2019
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@mtojek
Copy link
Contributor

mtojek commented Nov 26, 2019

Hi @alakahakai! Thank you for your input to elastic/beats. Could you please add a description here? I know it's a simple change, but it's welcome to put here some notes and describe your use case.

@alakahakai
Copy link
Author

Hi @alakahakai! Thank you for your input to elastic/beats. Could you please add a description here? I know it's a simple change, but it's welcome to put here some notes and describe your use case.

With the TLS/SSL setting, the httpjson input can be used with HTTPS REST services that use self-signed certificates, since the default golang TLS/SSL setting has InsecureSkipVerify set to false.

@alakahakai alakahakai changed the title Fix ssl config in input.yml for Filebeat httpjson input in the MISP module Fix SSLconfig in input.yml for Filebeat httpjson input in the MISP module Nov 26, 2019
@alakahakai alakahakai merged commit ada20e9 into elastic:master Dec 10, 2019
@alakahakai alakahakai added the needs_backport PR is waiting to be backported to other branches. label Dec 20, 2019
@alakahakai alakahakai mentioned this pull request Dec 20, 2019
Merged
@alakahakai alakahakai added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 20, 2019
mtojek pushed a commit that referenced this pull request Dec 23, 2019
@mtojek
Cherry-pick #14767 to 7.x: Fix SSLconfig in input.yml for Filebeat ht…
ffb7603 
…tpjson input in the MISP module (#15247)

* Fix SSLconfig in input.yml for Filebeat httpjson input in the MISP module (#14767)

* Add ssl config to input.yml and manifest.yml for Filebeat httpjson input in the MISP module.

(cherry picked from commit ada20e9)

* Fix CHANGELOG.next.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek left review comments

@andrewkroh andrewkroh andrewkroh approved these changes

@tsg tsg Awaiting requested review from tsg

Assignees
No one assigned
Labels
bug Filebeat Filebeat review v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alakahakai @mtojek @andrewkroh