Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit fileset to googlecloud module #15200

Merged
merged 23 commits into from Jan 4, 2020
Merged

Add audit fileset to googlecloud module #15200

merged 23 commits into from Jan 4, 2020

Conversation

alakahakai
Copy link

Add audit fileset to googlecloud module to support GCP audit log.

@alakahakai alakahakai requested a review from a team as a code owner December 19, 2019 01:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until ECS 1.3, event.type was reserved and should not have been used.

With ECS 1.4 we've started introducing the first allowed values for the 4 ECS categorization fields, event.type is one of them. If none of the values currently allowed per this new documentation section are fitting for this event source, the fields should be left empty for now.

Other than event.type, this LGTM though.

@alakahakai
Copy link
Author

alakahakai commented Dec 20, 2019

Up until ECS 1.3, event.type was reserved and should not have been used.

With ECS 1.4 we've started introducing the first allowed values for the 4 ECS categorization fields, event.type is one of them. If none of the values currently allowed per this new documentation section are fitting for this event source, the fields should be left empty for now.

Other than event.type, this LGTM though.

I can leave these two fields empty: event.category and event.type.

However, currently for the googlecloud module, vpcflow fileset uses the following:

var categorizeEvent = new processor.AddFields({
        target: "event",
        fields: {
            category: "network_traffic",
            type: "flow",
        },
    });

And firewall fileset uses:

builder.Add("categorizeEvent", new processor.AddFields({
        target: "event",
        fields: {
            category: "firewall-rule",
            type: "firewall"
        },
    }));

So the audit fileset sets these fields to be somehow consistent.

@webmat
Copy link
Contributor

webmat commented Dec 23, 2019

@alakahakai Every time I've one of the reserved fields being used, I've warned that it would have to change eventually, and that the fields shouldn't be used. Many times this was ignored 🤷‍♂

If you leave it like this, you're setting yourself up to have to change this module as well, in the 7.x line.

@alakahakai
Copy link
Author

alakahakai commented Dec 24, 2019

@alakahakai Every time I've one of the reserved fields being used, I've warned that it would have to change eventually, and that the fields shouldn't be used. Many times this was ignored 🤷‍♂

If you leave it like this, you're setting yourself up to have to change this module as well, in the 7.x line.

@webmat I will not set these two fields for now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants