Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Move HTTP calls to Kibana from New() to Fetch() (#15270) #15277

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.x:

* Move HTTP calls to Fetch() from New()

This makes the `kibana/stats` metricset resilient to Kibana's unavailability.

* Add special handling for errors when xpack.enabled is set to true

* Don't reinit usageLastCollectedOn
@ycombinator ycombinator requested a review from a team as a code owner December 31, 2019 13:38
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator ycombinator merged commit 1a91bea into elastic:7.x Dec 31, 2019
@ycombinator ycombinator deleted the backport/7.x/pr-15270 branch December 31, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants