Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-txfile and dependencies #15338

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Conversation

urso
Copy link

@urso urso commented Jan 6, 2020

  • github.com/theckman/go-flock has been renamed to
    github.com/gofrs/flock
  • go-txfile now relies on flock project on all platforms: Always creates
    a lock file
  • go-txfile returns and error and does not block anymore if the lock file is
    taken

- github.com/theckman/go-flock has been renamed to
  github.com/gofrs/flock
- go-txfile now relies on flock project on all platforms: Always creates
  a lock file
- go-txfile returns and error and does not block anymore if the lock file is
  taken
@urso urso requested a review from a team January 6, 2020 13:16
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've reviewed the other changes.

@urso
Copy link
Author

urso commented Jan 6, 2020

@ph fyi; Partially improves #10653, but beats spooling support can not distinguish between starting a Beat or just testing some configuration. Instead of hanging, the test config command will return an error if the spool file is used by a concurrently running Beat. I wonder if this can affect the Agent.

@ph
Copy link
Contributor

ph commented Jan 6, 2020

@ph fyi; Partially improves #10653, but beats spooling support can not distinguish between starting a Beat or just testing some configuration. Instead of hanging, the test config command will return an error if the spool file is used by a concurrently running Beat. I wonder if this can affect the Agent.

I think it could in a bad way, spooling to disk and upgrade path would be a pain. I need to create a followup issue on this problem.

@urso urso merged commit 79ec5c9 into elastic:master Jan 7, 2020
@urso urso deleted the upd/go-txfile-0.0.7 branch January 7, 2020 13:40
@urso urso added the v7.6.0 label Jan 7, 2020
urso pushed a commit to urso/beats that referenced this pull request Jan 7, 2020
* Update go-txfile and dependencies

- github.com/theckman/go-flock has been renamed to
  github.com/gofrs/flock
- go-txfile now relies on flock project on all platforms: Always creates
  a lock file
- go-txfile returns and error and does not block anymore if the lock file is
  taken

(cherry picked from commit 79ec5c9)
urso pushed a commit that referenced this pull request Jan 7, 2020
- github.com/theckman/go-flock has been renamed to
  github.com/gofrs/flock
- go-txfile now relies on flock project on all platforms: Always creates
  a lock file
- go-txfile returns and error and does not block anymore if the lock file is
  taken

(cherry picked from commit 79ec5c9)
@urso urso added the test-plan Add this PR to be manual test plan label Jan 14, 2020
@faec
Copy link
Contributor

faec commented Jan 24, 2020

Testing notes (from conversation with @urso):

  • check that events are still published if spooling to disk is enabled
  • check a lock file is generated on linux/macOS
  • starting a second beat using same spool file and running beat test config should not block but quit with an error

@faec faec added test-plan-ok This PR passed manual testing and removed needs testing notes labels Jan 24, 2020
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants