Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test output with ipv6 addresses #15368

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Fix test output with ipv6 addresses #15368

merged 2 commits into from
Jan 10, 2020

Conversation

onequid
Copy link

@onequid onequid commented Jan 7, 2020

Fixes #15078

Using u.Host would not break anything, as far as I can tell

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ChrsMark ChrsMark changed the title Fix test output with ipvs addresses Fix test output with ipv6 addresses Jan 8, 2020
@ChrsMark ChrsMark added bug v7.6.0 needs_backport PR is waiting to be backported to other branches. labels Jan 8, 2020
@ChrsMark ChrsMark requested a review from exekias January 8, 2020 09:27
@ChrsMark
Copy link
Member

ChrsMark commented Jan 8, 2020

Thanks for working on this @onequid !!! I tried your changes locally and it works!

@exekias could you have a look and confirm this change is safe 🙂 since you had created this function?

@ChrsMark ChrsMark self-assigned this Jan 8, 2020
@ChrsMark
Copy link
Member

ChrsMark commented Jan 8, 2020

jenkins, test this

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need a changelog

@ChrsMark
Copy link
Member

ChrsMark commented Jan 9, 2020

Thanks @exekias .

@onequid could you add a changelog entry please in https://github.com/elastic/beats/blob/master/CHANGELOG.next.asciidoc? I would say this should go under:

==== Bugfixes

*Affecting all Beats*

@onequid
Copy link
Author

onequid commented Jan 9, 2020

@ChrsMark sure, just added it. 😃

@ChrsMark
Copy link
Member

Thanks for working on this @onequid!

@ChrsMark ChrsMark merged commit 69f4600 into elastic:master Jan 10, 2020
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request Jan 10, 2020
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request Jan 10, 2020
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Jan 10, 2020
@onequid
Copy link
Author

onequid commented Jan 10, 2020

@ChrsMark my pleasure 😃

@onequid onequid deleted the gh-15078 branch January 31, 2020 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test output does not work with ipv6 addresses
5 participants